[REST API] Check Application Passwords status #8150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
added
type: enhancement
hichamboushaba
changed the base branch from
trunk
to
issue/8110-fetch-woo-status
7 tasks
Collaborator
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
Codecov ReportBase: 42.96% // Head: 42.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## trunk #8150 +/- ##
============================================
- Coverage 42.96% 42.94% -0.02%
Complexity 3484 3484
============================================
Files 685 685
Lines 37305 37316 +11
Branches 4950 4951 +1
============================================
Hits 16027 16027
- Misses 19835 19846 +11
Partials 1443 1443
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hichamboushaba
commented
Jan 10, 2023
Comment on lines
253
to
267
| private fun isGooglePlayServicesAvailable(context: Context): Boolean { | ||
| val googleApiAvailability = GoogleApiAvailability.getInstance() | ||
|
|
||
| return when (val connectionResult = googleApiAvailability.isGooglePlayServicesAvailable(context)) { | ||
| ConnectionResult.SUCCESS -> true | ||
| else -> { | ||
| WooLog.w( | ||
| T.NOTIFS, | ||
| "Google Play Services unavailable, connection result: " + | ||
| googleApiAvailability.getErrorString(connectionResult) | ||
| ) | ||
| return false | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
This is unrelated to this PR, but I noticed this function is not used anymore (confirmation #6535 (comment)), so I removed it.
JorgeMucientes
approved these changes
Jan 10, 2023
Contributor
|
Nice job there! Everything works as expected @hichamboushaba |
JorgeMucientes
deleted the
issue/8110-check-application-passwords-status
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #8110
Description
Testing instructions
Login
Check when using the app
Note: regarding the last test, we can probably do better, but for now this will do, the user will see the correct error message if they try to sign in to the same site. We'll add some tracking to track the number of cases where this happens, and decide if it's worth improvement or not.
Images/gif
The recording is choppy, I don't know why 😕
device-2023-01-09-174907.mp4
RELEASE-NOTES.txtif necessary.