Support tapping on links #8980
Merged
Support tapping on links #8980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
3 tasks
Collaborator
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## feature/new_privacy_screen #8980 +/- ##
=============================================================
Coverage 43.07% 43.08%
Complexity 3950 3950
=============================================================
Files 825 824 -1
Lines 43420 43410 -10
Branches 5667 5665 -2
=============================================================
Hits 18704 18704
+ Misses 23067 23057 -10
Partials 1649 1649
☔ View full report in Codecov by Sentry. |
…row' into issue/8939_support_link_actions
wzieba
requested review from
a team and
atorresveiga
and removed request for
a team
…row' into issue/8939_support_link_actions
Base automatically changed from
issue/8938_more_privacy_options_row
to
feature/new_privacy_screen
May 11, 2023 07:34
…to issue/8939_support_link_actions
| onCookiePolicyClicked: () -> Unit, | ||
| modifier: Modifier = Modifier | ||
| ) { | ||
| val privacyText = |
Contributor
There was a problem hiding this comment.
np: more than half of this composable is about creating the string with the links, maybe we can move this logic into a separate function. WDYT?
Contributor
Author
There was a problem hiding this comment.
Thanks! Good idea, but because of the recent design change and lack of this text - I removed this method.
wzieba
commented
May 11, 2023
Comment on lines
+32
to
+49
| PrivacySettingsPolicesScreen( | ||
| onPrivacyPolicyClicked = { | ||
| AnalyticsTracker.track(AnalyticsEvent.PRIVACY_SETTINGS_PRIVACY_POLICY_LINK_TAPPED) | ||
| ChromeCustomTabUtils.launchUrl( | ||
| requireActivity(), | ||
| AppUrls.AUTOMATTIC_PRIVACY_POLICY | ||
| ) | ||
| }, | ||
| onCookiePolicyClicked = { | ||
| AnalyticsTracker.track( | ||
| AnalyticsEvent.PRIVACY_SETTINGS_THIRD_PARTY_TRACKING_INFO_LINK_TAPPED | ||
| ) | ||
| ChromeCustomTabUtils.launchUrl( | ||
| requireActivity(), | ||
| AppUrls.AUTOMATTIC_COOKIE_POLICY | ||
| ) | ||
| } | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I've decided not to introduce VM to such a simple view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8939
Description
This PR ads behavior of opening correct links upon user clicks.
Testing instructions
Open Privacy Settings:
Images/gif
Mon.May.8.20.22.28.CEST.2023.mp4
RELEASE-NOTES.txtif necessary.