Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented May 9, 2023

Closes: #8979

Description

This PR removes Tracking events from Privacy Screens toggles (Analytics and Crash Reporting)

Testing instructions

Not needed

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wzieba wzieba added type: task An internally driven task. feature: privacy Related to the privacy choice projects labels May 9, 2023
@wzieba wzieba linked an issue May 9, 2023 that may be closed by this pull request
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 9, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@peril-woocommerce
Copy link

peril-woocommerce bot commented May 10, 2023

Warnings
⚠️ PR is not assigned to a milestone.
Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@wzieba wzieba marked this pull request as ready for review May 10, 2023 10:43
@wzieba wzieba requested a review from atorresveiga May 10, 2023 10:43
@wzieba wzieba mentioned this pull request May 10, 2023
1 task
@wzieba wzieba changed the title feat: remove tracking from Analytics switch action Remove tracking from Analytics switch action in Privacy Screen May 10, 2023
Copy link
Contributor

@atorresveiga atorresveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Copy link
Contributor

@atorresveiga atorresveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! :shipit:

Base automatically changed from issue/8939_support_link_actions to feature/new_privacy_screen May 11, 2023 18:22
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (46061a7) 43.08% compared to head (d4a40b4) 43.11%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             feature/new_privacy_screen    #8992      +/-   ##
================================================================
+ Coverage                         43.08%   43.11%   +0.02%     
  Complexity                         3950     3950              
================================================================
  Files                               824      824              
  Lines                             43410    43379      -31     
  Branches                           5665     5658       -7     
================================================================
- Hits                              18704    18702       -2     
+ Misses                            23057    23028      -29     
  Partials                           1649     1649              
Impacted Files Coverage Δ
...om/woocommerce/android/analytics/AnalyticsEvent.kt 100.00% <ø> (ø)
...merce/android/ui/prefs/PrivacySettingsViewModel.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wzieba wzieba merged commit bcfe51b into feature/new_privacy_screen May 12, 2023
@wzieba wzieba deleted the issue/8979_remove_analytics_switch_tracking branch May 12, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: privacy Related to the privacy choice projects type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Privacy Choices] Remove tracking Analytics switch

5 participants