-
Notifications
You must be signed in to change notification settings - Fork 137
Remove tracking from Analytics switch action in Privacy Screen #8992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tracking from Analytics switch action in Privacy Screen #8992
Conversation
|
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
…_analytics_switch_tracking
Generated by 🚫 dangerJS |
atorresveiga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ![]()
atorresveiga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! ![]()
…ytics_switch_tracking
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## feature/new_privacy_screen #8992 +/- ##
================================================================
+ Coverage 43.08% 43.11% +0.02%
Complexity 3950 3950
================================================================
Files 824 824
Lines 43410 43379 -31
Branches 5665 5658 -7
================================================================
- Hits 18704 18702 -2
+ Misses 23057 23028 -29
Partials 1649 1649
☔ View full report in Codecov by Sentry. |
Closes: #8979
Description
This PR removes Tracking events from Privacy Screens toggles (Analytics and Crash Reporting)
Testing instructions
Not needed
RELEASE-NOTES.txtif necessary.