Skip to content

Conversation

@AnirudhBhat
Copy link
Contributor

@AnirudhBhat AnirudhBhat commented May 18, 2023

Closes: #9055

Description

This PR adds an entry point to the "Scanned and Deliver" project in the Order listing screen. It basically adds a barcode icon in the toolbar in the order listing screen.

More context: pecCkj-GT-p2

Screenshot 2023-05-17 at 1 03 00 PM

Testing instructions

  1. Navigate to the orders listing screen
  2. Ensure you see the barcode icon in the toolbar
  3. Tap on the barcode icon
  4. Ensure the scanning screen opens

Images/gif

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 18, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

Base automatically changed from issue/8941-code-scanner-order-creation-ui to issue/8944-order-creation-search-product-by-sku May 19, 2023 07:53
@AnirudhBhat AnirudhBhat requested a review from samiuelson May 19, 2023 13:19
@AnirudhBhat AnirudhBhat added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label May 19, 2023
@AnirudhBhat AnirudhBhat marked this pull request as ready for review May 19, 2023 13:19
@peril-woocommerce
Copy link

peril-woocommerce bot commented May 19, 2023

Fails
🚫

Danger failed to run /app/danger-0.3s0oja67qc5.ts.

Warnings
⚠️ PR is not assigned to a milestone.

Error TypeError

Cannot read property 'diffForFile' of undefined
TypeError: Cannot read property 'diffForFile' of undefined
    at Object.exports.default (/app/danger-0.3s0oja67qc5.ts:27:46)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

22|     // Calculate the changes to Test files because we don't want to limit those
23|     // Note that linesOfCode() function in the latest GitDSL can solve this problem in a more elegant way,
24|     // but the version of Danger currently used by Peril doesn't have it yet.
25|     const testFiles = [...modifiedFiles, ...createdFiles, ...deletedFiles].filter((path: string) => path.includes("/src/test"));
26|     let changesToTests = 0;
------------------------------------------------^
27|     for (let file of testFiles) {        
28|         const stringDiffs = await danger.git.diffForFile(file)
29|         const addedLines = stringDiffs.added.split("\n").filter(x => x.startsWith("+")).length;
30|         const removedLines = stringDiffs.removed.split("\n").filter(x => x.startsWith("-")).length;

Generated by 🚫 dangerJS

Base automatically changed from issue/8944-order-creation-search-product-by-sku to trunk May 19, 2023 15:17
@AnirudhBhat AnirudhBhat added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 19, 2023
@AnirudhBhat AnirudhBhat enabled auto-merge May 22, 2023 02:27
@AnirudhBhat AnirudhBhat merged commit f5cb917 into trunk May 22, 2023
@AnirudhBhat AnirudhBhat deleted the issue/9055-code-scanner-order-listing-ui branch May 22, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. status: do not merge Dependent on another PR, ready for review but not ready for merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an entry point for adding products via barcode scanning in the order listing screen

4 participants