Skip to content

Add new prop to ORDER_CREATION_SUCCESS event #9075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2023
Merged

Add new prop to ORDER_CREATION_SUCCESS event #9075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions WooCommerce/src/main/kotlin/com/woocommerce/android/analytics/AnalyticsTracker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ class AnalyticsTracker private constructor(private val context: Context) {
const val KEY_TIME_ELAPSED_SINCE_ADD_NEW_ORDER_IN_MILLIS = "milliseconds_since_order_add_new"
const val KEY_TIME_ELAPSED_SINCE_CARD_COLLECT_PAYMENT_IN_MILLIS = "milliseconds_since_card_collect_payment_flow"

const val KEY_COUPONS_COUNT = "coupons_count"

enum class OrderNoteType(val value: String) {
CUSTOMER("customer"),
PRIVATE("private"),
Expand Down
4 changes: 3 additions & 1 deletion ...ce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/OrderCreateEditViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.woocommerce.android.analytics.AnalyticsEvent.ORDER_SHIPPING_METHOD_AD
import com.woocommerce.android.analytics.AnalyticsEvent.ORDER_SHIPPING_METHOD_REMOVE
import com.woocommerce.android.analytics.AnalyticsEvent.ORDER_STATUS_CHANGE
import com.woocommerce.android.analytics.AnalyticsTracker
import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_COUPONS_COUNT
import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_ERROR_CONTEXT
import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_ERROR_DESC
import com.woocommerce.android.analytics.AnalyticsTracker.Companion.KEY_ERROR_TYPE
Expand Down Expand Up @@ -432,11 +433,12 @@ class OrderCreateEditViewModel @Inject constructor(
private fun trackOrderCreationSuccess() {
tracker.track(
ORDER_CREATION_SUCCESS,
mutableMapOf<String, String>().also { mutableMap ->
mutableMapOf<String, Any>().also { mutableMap ->
OrderDurationRecorder.millisecondsSinceOrderAddNew().getOrNull()?.let { timeElapsed ->
mutableMap[AnalyticsTracker.KEY_TIME_ELAPSED_SINCE_ADD_NEW_ORDER_IN_MILLIS] =
timeElapsed.toString()
}
mutableMap[KEY_COUPONS_COUNT] = orderDraft.value?.couponLines?.size ?: 0
}
)
}
Expand Down