Skip to content

Update background colors of all cells in OrderDetails screen #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ctarda merged 5 commits into from
Oct 3, 2019
Merged

Update background colors of all cells in OrderDetails screen #1329

ctarda merged 5 commits into from
Oct 3, 2019

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented Oct 2, 2019

Fixes #1325

The scope of the PR is limited to just making the OrderDetails screen usable in Dark mode when building the codebase with the release version of Xcode 11.

Before:

After:

Changes

  • Set the background color of the cells involved in the rendering of the Order Details screen

Testing

  • Set a device to dark mode.
  • Checkout the branch, build the project, navigate to a single order.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ctarda ctarda added type: bug A confirmed bug. category: dark mode Related to dark mode. labels Oct 2, 2019
@ctarda ctarda added this to the 2.7 ❄️ milestone Oct 2, 2019
@ctarda ctarda requested review from jaclync and mindgraffiti October 2, 2019 20:46
@ctarda ctarda self-assigned this Oct 2, 2019
mindgraffiti
mindgraffiti reviewed Oct 2, 2019
View reviewed changes
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you're thinking about dark mode! Can you apply these changes to FulfillButtonTableViewCell as well? After that, :shipit:

jaclync
jaclync reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as Thuy pointed out, Fulfill Order button still has dark background

@ctarda ctarda mentioned this pull request Oct 3, 2019
Merged
1 task
@ctarda
Copy link
Contributor Author

ctarda commented Oct 3, 2019

🤦🏼‍♂️ how could I miss that..

I just pushed an update:

@ctarda ctarda requested review from jaclync and mindgraffiti October 3, 2019 16:31
mindgraffiti
mindgraffiti approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: still stands 😀

@ctarda ctarda merged commit 11e9167 into release/2.7 Oct 3, 2019
@mindgraffiti mindgraffiti mentioned this pull request Oct 4, 2019
Closed
@pmusolino pmusolino mentioned this pull request Oct 22, 2019
Closed
@astralbodies astralbodies deleted the issue/1325-darkmode-order-details branch January 7, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindgraffiti mindgraffiti mindgraffiti approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

@ctarda ctarda

Labels

category: dark mode Related to dark mode. type: bug A confirmed bug.

Projects

None yet

Milestone

2.7 ❄️

Development

Successfully merging this pull request may close these issues.

4 participants

@ctarda @mindgraffiti @jaclync