Skip to content

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented Oct 3, 2019

Fixes #1340

The scope of the PR is limited to just making the screen to Add a Note usable in Dark mode when building the codebase with the release version of Xcode 11.

Before:

After:

Note that the cell view marked with an arrow is fixed in PR #1337

Changes

  • Update the background of TextViewTableViewCell
  • Override dark mode for the text view embedded in it. It seemed to be a simpler solution, and simpler to revert, that preparing its background and font colors to support dark mode later on.

Review

  • Set a device in dark mode
  • Build the branch, navigate to an order in Processing status, and Add a Note.
  • If PR Set background colour of cells used in Settings #1337 has already been merged, the view should look ok. If it hasn't, the view should only look fine, except for the section corresponding to "Email note to customer:

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ctarda ctarda added type: bug A confirmed bug. category: dark mode Related to dark mode. labels Oct 3, 2019
@ctarda ctarda added this to the 2.7 ❄️ milestone Oct 3, 2019
@ctarda ctarda requested review from jaclync and mindgraffiti October 3, 2019 18:49
@ctarda ctarda self-assigned this Oct 3, 2019
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing: ✅ (same behavior as in screenshots)
Code: ✅

@ctarda ctarda merged commit 3a69743 into release/2.7 Oct 4, 2019
@ctarda ctarda deleted the issue/1340-darkmode-add-note branch October 4, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dark mode Related to dark mode. type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants