Skip to content

Conversation

@bummytime
Copy link
Contributor

@bummytime bummytime commented Jul 5, 2018

This PR takes core of some housekeeping work to support finishing up #26 — primarily setting up the Networking framework to support fetching order notes from the backend. Things this PR accomplishes:

  • Completely removes the fake-data and Models folder from the main WooCommerce project. 🎉
  • Adds the OrderNotes model to Networking
  • Adds the OrderNotesMapper + tests
  • Adds loadOrderNotes() toOrdersRemote + tests
  • Updates the OrderNoteViewModel to support using the Yosemite model
  • Updates OrderNoteTableViewCell to support changes in OrderNoteViewModel ☝️

There were also a few misc things that were also addressed:

  • Adds the missing OrderMapperTests that I failed to do in an earlier PR
  • Adds some missing "broken network" tests to OrdersRemoteTests (again, my bad)

Note: There will be a followup PR (or two) that will added the corresponding actions + functionality to the OrderStore (as well as remove the commented out "notes" code).

Testing

  1. Make sure the unit tests are green
  2. Build and run the app and make sure nothing blows up. 💣

@jleandroperez and/or @mindgraffiti Can you take a quick peek at this?

@bummytime bummytime added the feature: order details Related to order details. label Jul 5, 2018
@bummytime bummytime added this to the External closed beta milestone Jul 5, 2018
@bummytime bummytime self-assigned this Jul 5, 2018
@wpmobilebot
Copy link
Collaborator

1 Warning
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 Danger

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Every single test passes
✅ Vertical Alignment in constants!!

Looking great!!

static let ordersPath: String = "orders"
static let defaultPageSize: Int = 75
static let ordersPath: String = "orders"
static let notesPath: String = "notes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY ALIGNMENT!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always! 🤣

@bummytime
Copy link
Contributor Author

Thanks @jleandroperez !

@bummytime bummytime merged commit d877b7f into develop Jul 6, 2018
@bummytime bummytime deleted the feature/26-order-detail-notes branch July 6, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: order details Related to order details.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants