Adds Order storage + tests #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/97-order-storage * 'develop' of github.com:woocommerce/woocommerce-ios: (26 commits) StyleManager: New Style Addressing PR Feedback StorePickerViewController: Multiple Updates AccountHeaderView: Nuking Extra Spaces Implements EmptyStoresTableViewCell UIView+Helpers: New API's StorePickerViewController: Wiring AccountHeaderView Updates Project Implements AccountHeaderView Implements UIView+Helpers Implements NSObject+Helpers Style: New Property AuthenticationManager: Nuking credentials property StorePickerViewController: Adding Placeholder AccountStore: Fixing merge issue Style: Nukes (more) duplicated properties Style: Nuking duplicated properties Project: Fixing Merge Glitch Style: Fixing Hound Warning StorePickerViewController: Fixing Hound Warnings ...
… feature/97-order-storage * 'develop' of github.com:woocommerce/woocommerce-ios: UITableViewCellHelpersTests: Documents Unit Test UITableViewCellHelpersTests: Nukes extra whitespace Nukes unneeded constants Implements UITableViewCell+Helpers
… feature/97-order-storage * 'develop' of github.com:woocommerce/woocommerce-ios: Updating Authenticator to Mark 1.0.2 Podfile: Updating WordPressAuthenticator to Mark 1.0.2 AuthenticationManager: Wiring the new WordPressAuthenticatorDelegate API Podfile: Updating WordPressAuthenticator's reference
bummytime
added
feature: order details
Closed
Collaborator
Generated by 🚫 Danger |
jleandroperez
approved these changes
Jul 13, 2018
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
No suggestions!!! looking great, end to end!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds everything Storage (for now) to
Order,OrderItemsandOrderCoupons.The big rocks here include:
ReadOnlyConvertibleimplementationsNetworkingmodelsStorageType+Extensions.swiftOrderStore(triggered after orders are pulled down from the wire)Note:
OrderNoteis not included in this PR and will be added in a subsequent PR.Fixes #97
Testing