Skip to content

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Mar 11, 2025

Closes: #14885

Description

Show a custom error message when no label rates are available for the selected package and weight combination.

This error message follows the below web implementation.

image

Changes

  • New error case to handle no label rates available case.
  • Show custom error message when no label rates are available.

Steps to reproduce

  1. Log in to a test store with the Woo Shipping plugin set up.
  2. Create an order with multiple products and enter the quantity as more than 100 for each product. Select products with a lot of weight.
  3. Open the order detail page on the web and validate that no shipping label rates are available for this order due to the large amount of products and weight.
  4. Open the order detail page from the mobile app.
  5. Select Create shipping label > Select package.
  6. Make sure that you see an error message explaining that no label rates are available for this combination of the package and weight.

Testing information

I validated that a custom error message is displayed when no label rates are available for an order with a high product quantity and weight.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@selanthiraiyan selanthiraiyan added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Mar 11, 2025
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@selanthiraiyan selanthiraiyan added this to the 22.0 milestone Mar 11, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 11, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15322-a80fff1
Version21.9
Bundle IDcom.automattic.alpha.woocommerce
Commita80fff1
App Center BuildWooCommerce - Prototype Builds #13296
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@selanthiraiyan selanthiraiyan marked this pull request as ready for review March 11, 2025 16:19
@selanthiraiyan selanthiraiyan changed the title Shipping Labels] Show custom error when no label rates available [Shipping Labels] Show custom error when no label rates available Mar 11, 2025
@itsmeichigo itsmeichigo self-assigned this Mar 12, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @selanthiraiyan, the error state shows up correctly for me when testing with simulator iPhone 16 Pro iOS 18.2.

My only concern is that I don't think the Retry button is helpful in this case, as the only way to resolve the issue is to update the weight. Should we hide the retry button to avoid users requesting unnecessary updates for the same weights?

@selanthiraiyan
Copy link
Contributor Author

My only concern is that I don't think the Retry button is helpful in this case, as the only way to resolve the issue is to update the weight. Should we hide the retry button to avoid users requesting unnecessary updates for the same weights?

Good point, Huong!

I have removed the "Retry" button in a80fff1.

Normal error When no rates available for current package/weight combination
Simulator Screenshot - iPhone 16 Pro - 2025-03-12 at 17 50 07 Simulator Screenshot - iPhone 16 Pro - 2025-03-12 at 17 49 37

Base automatically changed from feat/15302-zero-weight to trunk March 12, 2025 12:34
@selanthiraiyan selanthiraiyan merged commit 74b52ab into trunk Mar 12, 2025
14 checks passed
@selanthiraiyan selanthiraiyan deleted the feat/15302-rates-failure branch March 12, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load shipping rates fails

4 participants