-
Notifications
You must be signed in to change notification settings - Fork 121
[Shipping Labels] Show custom error when no label rates available #15322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @selanthiraiyan, the error state shows up correctly for me when testing with simulator iPhone 16 Pro iOS 18.2.
My only concern is that I don't think the Retry button is helpful in this case, as the only way to resolve the issue is to update the weight. Should we hide the retry button to avoid users requesting unnecessary updates for the same weights?
Good point, Huong! I have removed the "Retry" button in a80fff1.
|


Closes: #14885
Description
Show a custom error message when no label rates are available for the selected package and weight combination.
This error message follows the below web implementation.
Changes
Steps to reproduce
Testing information
I validated that a custom error message is displayed when no label rates are available for an order with a high product quantity and weight.
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: