[Woo POS] Coupons: Filter out expired coupons from appearing in POS

[iamgabrielma]

Closes: WOOMOB-246

This PR intercepts mapping coupons to POSItems, and filters out those that are expired (if any), so are not shown in POS while still working normally for the rest of the app:

POS	App

Caveat: The coupon properties seem to be a bit miss leading: By the API documentation I'd expected we'd have two properties:

date_expires: The date the coupon expires, in the site's timezone.
date_expires_gmt: The date the coupon expires, as GMT (UTC).

However we only use date_expires in the app, which is received as UTC anyway from the site. ie: my testing site is in UTC+7, but the coupon expiration date assigned on creation is still in UTC:

dateExpires    Foundation.Date?    2025-04-14 00:00:00 UTC 

Testing information

• Create a coupon, and set it expiration date to the past, publish it.
• Navigate to Menu > Coupons > Observe how the coupon appears normally in the app as expired
• Now in POS, observe how the coupon does not appear in the Coupon list.

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	29398
	Version	PR #15527
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	c310bfe
	Installation URL	1tie1lekjnau8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[staskus]

However we only use date_expires in the app, which is received as UTC anyway from the site. ie: my testing site is in UTC+7, but the coupon expiration date assigned on creation is still in UTC:

This PR might explain it a bit #6686, but either way it looks like it _gmt is either not working properly or wasn't working properly. 🤔

@iamgabrielma could you check if there's a bug reported on WooCommerce? Worth creating it if it's not yet there.

[Copilot]

Pull Request Overview

This PR updates the POS coupon mapping logic to filter out expired coupons so that the POS only shows valid coupons while leaving the rest of the app behavior unchanged.

• Added filtering logic in the coupon-to-POS mapping function
• Introduced a dedicated unit test to verify that expired coupons are excluded from the POS list

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
Yosemite/YosemiteTests/PointOfSale/PointOfSaleCouponServiceTests.swift	Added unit tests to check that expired coupons are filtered out
Yosemite/Yosemite/PointOfSale/PointOfSaleCouponService.swift	Updated mapping function to filter expired coupons before mapping

[staskus]

👍 Thanks for the work.

I tried to look for issues in tests and implementation with timezones but I think it should be alright.

Are there are any concerns you have, e.g. pagination?

[staskus]

nit; you can chain .filter { } .compact { } functional programming way

Suggested change

	let now = Date()
	let nonExpiredCoupons = coupons.filter { coupon in
	guard let expirationDate = coupon.dateExpires else { return true }
	return expirationDate >= now
	}
	return nonExpiredCoupons.compactMap { coupon in
	.coupon(POSCoupon(id: UUID(),
	code: coupon.code,
	summary: coupon.summary(currencySettings: currencySettings)))
	return coupons
	.filter {
	guard let expirationDate = $0.dateExpires else { return true }
	return expirationDate >= Date()
	}
	.compactMap {
	.coupon(
	POSCoupon(
	id: UUID(),
	code: $0.code,
	summary: $0.summary(currencySettings: currencySettings)
	)
	)
	}

[iamgabrielma]

TIL! I'll leave it with the existing implementation for now just because I feel it's more explicit, which makes it easier to read.

[iamgabrielma]

Are there are any concerns you have, e.g. pagination?

I think we could see edge cases where pagination is not triggered correctly if we have a merchant with a bunch of coupons expired on the first fetch (~10+), and nothing else saved locally, since the infiniteScrollTriggerDeterminer merely checks the scroll position. The same could happen for subsequent pages if they happen to have a full page or results where all coupons are expired.

I don't think we should optimize for it right now, but perhaps makes a stronger case to go with "let's render expired coupons as well, rather than hide them".

[staskus]

I think we could see edge cases where pagination is not triggered correctly if we have a merchant with a bunch of coupons expired on the first fetch (~10+), and nothing else saved locally, since the infiniteScrollTriggerDeterminer merely checks the scroll position. The same could happen for subsequent pages if they happen to have a full page or results where all coupons are expired.

@iamgabrielma got it. I don't like these edge cases. I'll bring up the question to the team.