Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Apr 21, 2025

Addresses part of WOOMOB-338

Description

When creating a new shipment by selecting all items, it results in an issue where a N+1 shipment gets created according to notice. This pr addresses the issue by restricting the "New shipment" option appearing in case if all items of the current shipment are selected.

Steps to reproduce

  • Log in to a test store with WooShipping set up.
  • Open a completed order with more than one physical item of different quantities.
  • Tap Create shipping label > Split shipments > move items into separate shipments
  • Open the newly created shipment tab.
  • Select all items.
  • Tap on "Move to" -> "New shipment"
  • The info toast will appear saying that items were moved to shipment N+1.

Снимок экрана 2025-04-21 в 18 25 51 Снимок экрана 2025-04-21 в 18 25 57

Testing information

  • Follow the testing steps until all items selection.
  • Tap on "Move to"
  • Make sure that the "New shipment" option doesn't appear.
  • Deselect one of items to make the selection incomplete.
  • Tap on "Move to" again.
  • The "New shipment" option should now be available.

Screenshots

Before After
Simulator Screenshot - iPhone 16 Pro - 2025-04-21 at 18 17 45 Simulator Screenshot - iPhone 16 Pro - 2025-04-21 at 18 16 29

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@RafaelKayumov RafaelKayumov added type: bug A confirmed bug. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Apr 21, 2025
@RafaelKayumov RafaelKayumov added this to the 22.3 milestone Apr 21, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 21, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number29448
VersionPR #15532
Bundle IDcom.automattic.alpha.woocommerce
Commitb25693a
Installation URL03312tjhp2va8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the fix on simulator iPhone 16 Pro iOS 18.2. Code changes look good to me :shipit:

@itsmeichigo itsmeichigo self-assigned this Apr 23, 2025
@RafaelKayumov RafaelKayumov merged commit ac32870 into trunk Apr 23, 2025
14 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-338-restrict-new-shipment-option branch April 23, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants