Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Apr 22, 2025

Closes: WOOMOB-357

Description

This PR makes the product restrictions banner and modal (simple/variable products only) less prominent.

  • Removes the banner from the ItemList
  • Removes the i button from the header
  • Adds a menu item to show the modal

Steps to reproduce

  1. Delete the app to ensure you don't have the banner dismissal stored in user defaults
  2. Build and run the app, then log in
  3. Navigate to POS
  4. Observe that the product restrictions banner is not shown, and nor is the i button
  5. Tap the ... menu, then Where are my products?
  6. Observe that the product restrictions modal is shown, and you can interact with it as you'd expect.

Testing information

Note that this allows the POS to be closed from new parts of the flow, by tapping Create order in store management. I've tested that payments are correctly cancelled if you do this while waiting for a customer to tap their card, and it can't be done during a card payment as the menu is inaccessible.

I've tested on an iPad Air running iOS 17.7.3, and a simulator running iOS 18.4

Screenshots

move.product.restrictions.banner.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Apr 22, 2025
@joshheald joshheald added this to the 22.3 milestone Apr 22, 2025
@joshheald joshheald requested a review from staskus April 22, 2025 11:47
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 22, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number29445
VersionPR #15539
Bundle IDcom.automattic.alpha.woocommerce
Commit6cf7621
Installation URL0a5o6qg3o4d0g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald marked this pull request as ready for review April 22, 2025 12:01
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this! Looks well. 👍

@joshheald joshheald enabled auto-merge April 22, 2025 13:34
@joshheald joshheald merged commit d3bac78 into trunk Apr 22, 2025
13 checks passed
@joshheald joshheald deleted the woomob-357-woo-pos-replace-a-product-banner-with-a-menu-item branch April 22, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants