Skip to content

Conversation

@iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Oct 9, 2025

Closes AINFRA-1376: WCiOS: Validate that release version sent by ReleasesV2 matches the project

Description

This PR updates the code freeze process to use the release version provided by ReleasesV2 as the source of truth.

The code freeze Buildkite pipeline now passes the RELEASE_VERSION environment variable to the code_freeze Fastlane lane.
If there's a mismatch between the passed version and the project calculated version, a warning is displayed to help identify configuration discrepancies, but the ReleasesV2 version is always used.

Testing

The code freeze lane has several side effects like potentially changing the version in the main branch, creating a release branch, updating release notes, etc, making it hard to easily test it. We can run a couple of tests locally commenting out parts of the lane, but they'll only test a minor part of the lane.
The changes will then be fully tested in the next release cycle during code freeze.

@iangmaia iangmaia self-assigned this Oct 9, 2025
@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Oct 9, 2025
@iangmaia iangmaia added this to the 23.5 milestone Oct 9, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 9, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16232-0425644
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit0425644
Installation URL41osund78mmi8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@AliSoftware
Copy link
Contributor

I have the same feedback as on https://github.com/bloom/DayOne-Android/pull/6612#pullrequestreview-3319847686, and given there's a batch of those PRs across repos, so let's focus the code review feedback on that single DOAndroid PR to avoid spreading the discussions, and merge the various repo's PRs all at once once the feedback have been addressed across all of them :)

@iangmaia iangmaia merged commit 67041f2 into trunk Oct 10, 2025
13 checks passed
@iangmaia iangmaia deleted the iangmaia/add-release-version-validation branch October 10, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants