Skip to content

Conversation

@bummytime
Copy link
Contributor

napkin 78 07-26-18 9 10 30 pm

This PR does the following:

  • Now captures all of the login analytics emitted by WordPressAuthenticator via the WordPressAuthenticatorDelegate
  • Tracks the logout event in SettingsViewController
  • Explicitly adds the WordPressShared pod to our Podfile (it is needed in WooAnalyticsStat.swift to convert a WPAnalyticsStat to a WooAnalyticsStat)

Fixes: #33

Testing

First, blow away 💥 the ./Pods folder in your local repo and run pod install. Then launch XCode and make sure the app builds and the unit tests are ✅.

Next run through the various Authentication flows while verifying that you are seeing logs like:

🔵 Tracked login_email_form_viewed

in the console. You should not see any logs like:

⚠️ Could not convert WPAnalyticsStat with value: 99

Finally after a few minutes, open the tracks live view and verify you see the auth/logout events.


@jleandroperez & @mindgraffiti would either of you mind taking a peek at this?

… feature/33-login-analytics

* 'develop' of github.com:woocommerce/woocommerce-ios:
  OrderStoreTests: Fixing Typo
  OrderStoreTests: Optimistic Failure Recovery
  OrderStore: Optimistic Status Update
  NoticePresenter: Nuking extra space
  NoticeView: Woo Style!
  Revert "Revert to this commit to test Foreground Notifications"
  Revert to this commit to test Foreground Notifications
  NoticePresenter: Disabling BG Notifications
  AppDelegate: Updating Notice Presenter's property
  AppDelegate: New Notice property
  @frosty's AWESOME Notice[View + Presenter + NotificationInfo]
  Implements Array+Helpers
  OrderStoreTests: New Test!
  OrderStore: .updateOrder Support
  OrderAction: UpdateOrder support
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all unit tests passing ✅
events reporting in console ✅
events reporting in tracks ✅

Working great, thank you @bummytime.

One question: an event reported as:
WooCommerce[50670:2387890] 🔵 Tracked signed_in, properties: [AnyHashable("dotcom_user"): "true", AnyHashable("multifactor"): "false"]. I use 2FA to log in. Does "multifactor" mean something else?

@mindgraffiti
Copy link
Contributor

Shipping on behalf of Bummy, who is AFK today :)

@mindgraffiti mindgraffiti merged commit 6e4523e into develop Jul 27, 2018
@mindgraffiti mindgraffiti deleted the feature/33-login-analytics branch July 27, 2018 16:48
@bummytime
Copy link
Contributor Author

Thanks for reviewing and merging this @mindgraffiti!

One question: an event reported as:
WooCommerce[50670:2387890] 🔵 Tracked signed_in, properties: [AnyHashable("dotcom_user"): "true", AnyHashable("multifactor"): "false"]. I use 2FA to log in. Does "multifactor" mean something else?

TBH, I am just forwarding along the props dictionary that the Authenticator pod sends to our delegate. Perhaps this is a bug there? Maybe @jleandroperez has some insight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants