Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
WordPressAuthenticatorvia theWordPressAuthenticatorDelegateSettingsViewControllerWordPressSharedpod to ourPodfile(it is needed inWooAnalyticsStat.swiftto convert aWPAnalyticsStatto aWooAnalyticsStat)Fixes: #33
Testing
First, blow away 💥 the
./Podsfolder in your local repo and runpod install. Then launch XCode and make sure the app builds and the unit tests are ✅.Next run through the various Authentication flows while verifying that you are seeing logs like:
🔵 Tracked login_email_form_viewedin the console. You should not see any logs like:
⚠️ Could not convert WPAnalyticsStat with value: 99Finally after a few minutes, open the tracks live view and verify you see the auth/logout events.
@jleandroperez & @mindgraffiti would either of you mind taking a peek at this?