More WPAuth styling options #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note: Updated the Issue Description so that this PR will close Issue #146. @mindgraffiti please let us know whenever this one is ready for review, thank you!!! |
Contributor
Author
|
Merge conflicts fixed. Ready for review @jleandroperez 🔢 |
jleandroperez
approved these changes
Aug 7, 2018
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
Thanks for getting this patched up @mindgraffiti !!!
Contributor
Author
|
thanks for the review Jorge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the WordPressAuthenticator-iOS framework now has new styling options exposed for use by the host apps,
navBarImage, andviewControllerBackgroundColor.Closes #146
Before & After:
