Skip to content

Fix: iTunes Connect Error #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2018
Merged

Fix: iTunes Connect Error #199

merged 3 commits into from
Jul 30, 2018

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 30, 2018

Details:

  • iOS 11 dropped ARMv7 support
  • The WooCommerce project (and the internal frameworks) had ARMv7 listed among the valid architectures
  • CocoaPods dependencies also supported ARMv7

As a result, iTunes Connect was throwing the error pasted below. The fix consists on:

  • Nuking ARMv7 from Woo. Since our iOS Deployment Target is set to iOS 11, this doesn't really affect our initial target audience.
  • Adding an (ugly) workaround in our Podfile, so that ARMv7 is no longer supported.

cc @bummytime @astralbodies

Dear Developer,

We identified one or more issues with a recent delivery for your app, "WooCommerce powered by Jetpack". Your delivery was successful, but you may wish to correct the following issues in your next delivery:

Too many symbol files - These symbols have no corresponding slice in any binary [0E631D01-400A-3AEE-9DB2-84D2FEC14BC2.symbols, 1914BE6B-C6DC-32C4-9502-8F239944CEF3.symbols, 24CE9B01-81AF-3BE8-81A8-188E2FD3117A.symbols, 3E83B10B-A473-3DA3-A196-9D85A874D2A0.symbols, 45DA3930-ED53-3CCD-8715-9C397D48EC28.symbols, 602C4AAD-B3FC-37BC-BF6D-EA231816B1F3.symbols, 7811DF65-0620-355A-8576-5BE825EB97DB.symbols, 8281EC52-3EEA-38BE-9256-C09BB700D4A6.symbols, A29076C2-AF2D-3075-B03C-24D92915CE74.symbols, A90FBA6F-AB7E-32FC-ADCA-E3CDBBB16D7B.symbols, AED92BFB-88CE-3292-AB8D-760A0198C111.symbols, AEDE3702-CFA3-361F-AA5C-5F9F0D1EA91D.symbols, B8580D9C-9011-36E0-91DE-6B4980A095A8.symbols, C5674E3E-8159-3551-BBBE-CF67D9F389AA.symbols, CA010E1A-313D-37B0-B9B2-FE2EC1D46ED8.symbols, DB809186-7331-3CC0-B4DE-42E9CD725EDB.symbols, F6FBF50B-5591-387C-BD8F-2D43D097A0A1.symbols, F79EDD16-57BE-3128-829A-A033D02AFC1E.symbols, F9419F3E-6131-3E62-9B9C-8A01124CF411.symbols]

@jleandroperez jleandroperez added the type: bug A confirmed bug. label Jul 30, 2018
@jleandroperez jleandroperez added this to the External closed beta milestone Jul 30, 2018
@jleandroperez jleandroperez self-assigned this Jul 30, 2018
@jleandroperez jleandroperez requested a review from bummytime July 30, 2018 17:59
bummytime
bummytime approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sleuthing @jleandroperez 🕵️

:shipit:

@jleandroperez
Copy link
Contributor Author

jleandroperez commented Jul 30, 2018

Thank you Matt!!!

@jleandroperez jleandroperez merged commit e1ee597 into develop Jul 30, 2018
@jleandroperez jleandroperez deleted the issue/itunes-connect-error branch July 30, 2018 18:23
@jleandroperez jleandroperez mentioned this pull request Aug 3, 2018
Merged
@jleandroperez jleandroperez mentioned this pull request Sep 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bummytime bummytime bummytime approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jleandroperez jleandroperez

Labels

type: bug A confirmed bug.

Projects

None yet

Milestone

External closed beta

Development

Successfully merging this pull request may close these issues.

3 participants

@jleandroperez @bummytime