EntityListener: ReadOnly.Entity <> Storage.Entity Bindings! #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
added
the
category: architecture
jleandroperez
changed the title
bummytime
approved these changes
Aug 8, 2018
Contributor
bummytime
left a comment
bummytime
left a comment
There was a problem hiding this comment.
@jleandroperez we have had a TON of offline discussion around the changes here. Everything looks good — unit tests are ✅ and app builds and runs as expected.
Contributor
Author
|
Thanks a TON @bummytime !!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pendings:
representsimplementation in: [Storage.OrderCoupon, Storage.OrderNote, Storage.OrderItem]Details:
ReadOnlyTypeprotocol: This allows us to match a Storage.Entity <> Yosemite.Entity.Closes #212
Testing:
Please: verify the unit tests pass!