-
Notifications
You must be signed in to change notification settings - Fork 120
Top performers Mark2: Storage + Yosemite fmwk support #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… feature/178-top-performers-mark2 * 'develop' of github.com:woocommerce/woocommerce-ios: (25 commits) OverlayMessageView: Updating StackView Distribution OverlayMessageView: MessageLabel is now multiline OrdersViewController: Removes extra spaces OverlayMessageView: Attach now disables tAMC OrdersViewController: Updates message OrdersViewController: Removes extra space OrdersViewController: Documents transitions OrdersViewController: Supporting Empty + Filtered State OrdersViewController: Reverts Testing Code Revert to this commit to test: Error State Revert to this commit to test: Empty State OrdersViewController: Handling "Share your Store" Action OrdersViewController: State Management OrdersViewController: Updates Sync Signature OrdersViewController: Placeholder Orders Management OrdersViewController: Wire renamed constants OrdersViewController: Implements FSM Management OrdersViewController: Nes State Enum Implements OverlayMessageView UIImage+Woo: New Assets ...
Generated by 🚫 Danger |
jleandroperez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. End to end!!!
Awesome work Matt!!! ![]()
| ## Model 2 | ||
| - @bummytime 2018-09-05 | ||
| - Added new entity: `TopEarnerStats`, to encapsulate all of the top earner stats for a given site & granularity | ||
| - Added new entity: `TopEarnerStatsItem`, to encapsulate all the top earner stats for a specific product |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!!!!
Error TypeErrorDangerfileGenerated by 🚫 dangerJS |
This PR adds support for Top Earners in Storage and Yosemite.
Storage
2 new Storage entities were added:
TopEarnerStatsandTopEarnerStatsItem:In addition, the data model is now versioned (
Model 2) and a light migration should take place for this change. To help matters going forward, I addedStorage/Storage/Model/MIGRATIONS.mdto help us keep track of and changes to the data model (just like WPiOS).Yosemite
In the Yosemite fmwk,
StatsStoreandStatsActionwere updated to handle top earners network + storage logic (viaretrieveTopEarnerStats()).Also, I added a bunch of unit tests to support all of this new logic 👆👆👆.
Ref: #178
Testing
No UI to test this out yet, so verify the unit tests are ✅ and the code looks acceptable.
@jleandroperez would you mind taking a peek?