Skip to content

Fix: iTC Warning "Too Many Symbols" #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2018
Merged

Fix: iTC Warning "Too Many Symbols" #327

merged 3 commits into from
Sep 24, 2018

Conversation

@jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Sep 24, 2018 •
edited by bummytime
Loading

Details:

  • Our deployment target is iOS 11 (which dropped 32 bit support).
  • The iTC Warning "Too Many Symbols" is about: Connect getting symbols for 32 bit architectures (ARMv7)

In this PR we're switching the "Valid Architectures" to the ARCHS_STANDARD_64_BIT constant. Plus: more CocoaPods Workarounds.

cc @bummytime @mindgraffiti (Thaaankyooou!!!)
Closes #290

Testing:

  • Verify the app builds correctly against the simulator (with no extra new warnings)
  • Verify the app builds correctly against the device
  • Verify that archiving the app doesn't produce any kind of errors

@jleandroperez jleandroperez added the type: bug A confirmed bug. label Sep 24, 2018
@jleandroperez jleandroperez added this to the External open beta milestone Sep 24, 2018
@jleandroperez jleandroperez self-assigned this Sep 24, 2018
@jleandroperez jleandroperez changed the base branch from develop to release/0.8 September 24, 2018 15:46
bummytime
bummytime approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jleandroperez!

:shipit:

@jleandroperez
Copy link
Contributor Author

jleandroperez commented Sep 24, 2018

Thank you Matt!!!

@jleandroperez jleandroperez merged commit f63daaa into release/0.8 Sep 24, 2018
@bummytime bummytime mentioned this pull request Sep 24, 2018
Closed
@jleandroperez jleandroperez deleted the issue/290-fixing-too-many-symbols-warning branch September 24, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindgraffiti mindgraffiti Awaiting requested review from mindgraffiti

1 more reviewer

@bummytime bummytime bummytime approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jleandroperez jleandroperez

Labels

type: bug A confirmed bug.

Projects

None yet

Milestone

External open beta

Development

Successfully merging this pull request may close these issues.

3 participants

@jleandroperez @bummytime