Open beta analytics #336
Merged
Open beta analytics #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
approved these changes
Sep 26, 2018
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
✅ Code looks great!!
✅ Unit Tests
✅ Device Testing: Logged Off / Logged On States
| } | ||
|
|
||
| override func tabBar(_ tabBar: UITabBar, didSelect item: UITabBarItem) { | ||
| guard let currentlySelectedTab = WooTab(rawValue: selectedIndex), |
Contributor
There was a problem hiding this comment.
Missing super.tabBar call?
Contributor
Author
There was a problem hiding this comment.
@jleandroperez I am not going to include the super call here...adding it caused the app to crash.
…into issue/open-beta-analytics-mark1 * 'release/0.8' of github.com:woocommerce/woocommerce-ios: OrderDetailsViewController: Fixing Typo SettingsViewController: Fixing Typo BillingDetailsTableViewCell: Applying gesture recognizer to the main view OrderDetailsViewController: Email Composer Appearance Updating Info.plist Project: ARCHS_STANDARD_64_BIT by default Podfile: 64 Bit Workaround # Conflicts: # WooCommerce/Classes/ViewRelated/Orders/OrderDetails/OrderDetailsViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all of the analytics defined in our Android+iOS event spreadsheet (ask me in Slack about this) to the open beta workflows.
Fixes #34
Testing
Make sure the app builds + runs & the unit tests are ✅ . Also try to give the entire app a good smoke test and make sure none of the newly-added instrumentation breaks anything.
/cc @loremattei