Skip to content

Conversation

@bummytime
Copy link
Contributor

3

Just some small layout tweaks for NoteTableViewCell — makes dynamic type work better.

Ref: #19

Testing

  1. Build and run the app
  2. Increase the type size in Settings (or use the Accessibility inspector with the sim - note, you may have to stop and re-launch the app to get the newly-changed settings to render properly)
  3. Verify everything in the Notifications lists looks ok (with various type sizes)

@jleandroperez a quick peek if you don't mind?

@bummytime bummytime added feature: notifications Related to notifications or notifs. category: accessibility Related to accessibility. labels Nov 15, 2018
@bummytime bummytime added this to the 0.11 milestone Nov 15, 2018
@bummytime bummytime self-assigned this Nov 15, 2018
@astralbodies astralbodies mentioned this pull request Nov 15, 2018
39 tasks
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks just perfect!!!

:shipit:

@bummytime bummytime merged commit 8db5f53 into develop Nov 16, 2018
@bummytime bummytime deleted the issue/19-dynamic-type branch November 16, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: accessibility Related to accessibility. feature: notifications Related to notifications or notifs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants