Simple Payments: Update pending order from Summary screen

[Ecarrion]

part of #5483

Why

Previous PR #5502 took care of rendering proper taxes on the summary screen, this PR takes care of updating the order remotely with the user selection.

PS: This PR just updates the order, does not navigate to any new screen, and does not handle errors yet.

How

• Updates OrderFeeLine to encode its ID. In order to be able to update the simple payment fee with taxable or not taxable status

• Updates OrdersRemote to support encoding fee lines when updating an order

• Updates OrderStore with an action to update a simple payments order.

• Update SummaryViewModel:

  • Receive via DI all the necessary fields in order to update an order
  • Call the update order action
  • Provide a loadingIndicator property

• Update SummaryView to consume the new values from its VM

Demo

update-order.mov

Testing

Prerequisites

• Make sure you are using an IPP eligible store
• Make sure you have a store with taxes set for your store location

Steps

• Start the simple payments flow
• Enter an amount & tap next
• Enter email, modify taxes, edit note
• Tap "Take Payment Button"
• See a loading spinner on the button
• After it finishes, dismiss the flow and check the order detail to corroborate the changes have been correctly made

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-woocommerce]

You can trigger an installable build for these changes by visiting CircleCI here.

[rachelmcr]

Nice! The changes are clear and test well. 👍

---

Not blocking or specific to this PR, but an observation from my testing:

At first I thought perhaps the note wasn't getting updated when the order was updated. Because it's called "Order Note" in the Simple Payments UI, I looked in the "Order notes" section in the order detail (check both in the app and in wp-admin) expecting to see the note there. It wasn't until I looked again at the code that I realized this note was going into the customer notes section.

I know this behavior has been discussed before, but I'm not sure if it's something we'd reconsider. Aside from the naming confusion, I also expect that customer-provided notes are only things the customer needs to communicate to the merchant (e.g. shipping/delivery instructions) while the order notes a merchant might enter while creating an order would be either for internal purposes (e.g. noting what the payment was for) or for communicating something to the customer with the order confirmation.

Screenshots:

Simple payments - Order Note field	Order details in app	Order details in wp-admin

[Ecarrion]

Hi @rachelmcr Thanks for the review. I agree that the naming is a bit confusing 🤔

We have decided to use the "customer provided note" for some reasons:

• It gets rendered in the receipt
• Information does not get lost within other notes as there could be a lot of auto-generated notes when making payments and updating statuses.
• Order note API requires a separate API call.

What are your thoughts on this @adamzelinski?

[ghost]

Hey, @Ecarrion @rachelmcr I agree and I'm happy to use 'Customer Provided Note' too. Thanks!

[Ecarrion]

Cool, I will update the name to "Customer Provided Note" to avoid confusion.
cc @nbradbury