Skip to content

Simple Payments: Clean code necessary for building payment links #6600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ecarrion merged 2 commits into from
Apr 8, 2022
Merged

Simple Payments: Clean code necessary for building payment links #6600

Ecarrion merged 2 commits into from
Apr 8, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Apr 7, 2022

Why

Now that payment links are fetched directly from the Order API #6594, it is time to delete the code that was needed to build payment links client side.

How

  • Delete code related to sync and store Advanced Site Settings.
  • Delete code related to get the Payments Page from the Advance Site Settings.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the feature: order creation All tasks related to creating an order label Apr 7, 2022
@Ecarrion Ecarrion added this to the 9.0 milestone Apr 7, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 7, 2022

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: pr6600-34326a1. IPA is available here. If you need access to this, you can ask a maintainer to add you.

ealeksandrov
ealeksandrov approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Ecarrion Ecarrion merged commit 32b1587 into trunk Apr 8, 2022
@Ecarrion Ecarrion deleted the issue/clean-simple-payments-requests branch April 8, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: order creation All tasks related to creating an order

Projects

None yet

Milestone

9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Ecarrion @wpmobilebot @ealeksandrov