Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

Part of #6489

Description

This PR adds some adjustments to the buttons in the product selector view:

  • Update the title of the view based on whether the view is for selecting or excluding products.
  • Remove the Done button from the navigation bar and add one for completing the selection at the bottom.
  • Add a banner on top of the product list with 2 buttons: Select All and Filter. The Select All button is not doing anything at the moment, and the Filter button only shows the filter screen and hasn't handled any filter updates yet.

In the next PR, we'll need to duplicate the current selector data source and add updates to that.

Testing instructions

Since the product selector screen hasn't got an entry point from the coupons flow, let's test the linked product flow instead.
With the couponEdit feature flag on:

  • Navigate to the Products tab > select a Product > Add more details > Linked products > Add Products > Add Products.
  • Notice that the title of the view now stays the same no matter how many products are selected.
  • Notice that there's a bar at the top with 2 buttons: Select All and Filter.
  • Select one or more products on the list. Notice that when there's at least one product selected, a button shows up at the bottom with a title indicating the number of products selected. Tapping this button completes the selection and dismisses the view.

With the couponEdit feature flag on: repeat the first step above and notice that the product selector view stay the same as before.

Screenshots

Before After

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: coupons Related to basic fulfillment such as order tracking. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Apr 8, 2022
@itsmeichigo itsmeichigo added this to the 9.0 milestone Apr 8, 2022
@itsmeichigo itsmeichigo requested a review from pmusolino April 8, 2022 09:20
@pmusolino pmusolino self-assigned this Apr 8, 2022
@wpmobilebot
Copy link
Collaborator

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: pr6603-ba47381. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Copy link
Contributor

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Base automatically changed from issue/6489-product-selection-alt to trunk April 8, 2022 10:07
@itsmeichigo itsmeichigo merged commit 351ef00 into trunk Apr 8, 2022
@itsmeichigo itsmeichigo deleted the issue/6489-product-selection-ui-update branch April 8, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: coupons Related to basic fulfillment such as order tracking. status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants