[Order Details] Fix race condition for missing products request #7142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7132
Description
This PR fixes race condition in Order Details screen, so products are always correctly loaded and displayed in edit flow.
Also it prevents some empty products sync requests when no data update is needed.
How
The method
syncEverythinginOrderDetailsViewModelhave separatesyncOrder()andsyncProducts()calls which are run in parallel.In fact, products sync depends on order, because simple order (from the list, non-cached previously) doesn't have
itemsdata with product ids to sync at all. This is an edge case, because usually products and/or order are already cached.Testing
Screenshots
RELEASE-NOTES.txtif necessary.