Skip to content

Change order of sections in Order Details screen #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ctarda merged 1 commit into from
May 30, 2019
Merged

Change order of sections in Order Details screen #992

ctarda merged 1 commit into from
May 30, 2019

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented May 27, 2019 •
edited
Loading

Fixes #990

As pointed out in #990, the Tracking section was shown right after Products, when it should be displayed right after Payments.

This PR is against the release/1.9 branch

Before and after:

Changes

  • Update the order of the table view sections. The new order is, from top to bottom: summary, products, customerNote, customerInformation, payment, tracking, notes

Testing

  • Checkout the branch, navigate to an order that contains shipment trackings. Note the placement of the "Trackings" section

Testfilght release notes:

  • Move the Tracking section in the Order Details screen below the Payment section

@ctarda ctarda added type: bug A confirmed bug. feature: order details Related to order details. feature: fulfillment Related to basic fulfillment such as order tracking. category: woo extensions Related to WC extensions or plugins. labels May 27, 2019
@ctarda ctarda added this to the 1.9 ❄️ milestone May 27, 2019
@ctarda ctarda self-assigned this May 27, 2019
@ctarda ctarda changed the base branch from develop to release/1.9 May 27, 2019 23:47
astralbodies
astralbodies approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@astralbodies astralbodies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! :shipit:

@ctarda ctarda merged commit dc2ab7c into release/1.9 May 30, 2019
@ctarda ctarda deleted the issue/990-tacking-order branch May 30, 2019 01:24
@ctarda ctarda mentioned this pull request Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindgraffiti mindgraffiti Awaiting requested review from mindgraffiti

2 more reviewers

@astralbodies astralbodies astralbodies approved these changes

@kyleaparker kyleaparker kyleaparker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ctarda ctarda

Labels

category: woo extensions Related to WC extensions or plugins. feature: fulfillment Related to basic fulfillment such as order tracking. feature: order details Related to order details. type: bug A confirmed bug.

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

4 participants

@ctarda @astralbodies @kyleaparker