Fix copy/paste of attributed string from app without support for dark/light mode

[SergioEstevao]

Fixes #wordpress-mobile/WordPress-iOS#12688

This PR implements three fixes to sort issues around text color:

• When copy/paste attributed string it makes sure that text color is set to default color if no color is set
• It also make sure that when all text is deleted the typing attributes are reset to default attributes that include the default color
• Make sure that the defaultColor is used for default attributes where converting from HTML mode.

To test:

• Copy paste text from other apps. Examples: Notes app, Tumblr in post edit mode, inside different sections of Aztec
• Open the demo app, put the cursor over the text with the red color, switch to HTML mode, and switch back to visual. Check that text is displayed in the correct color.
• Open the demo app, select all the text and delete it. Start to type check that the text shows with the default attributes and not with the attributes of the last selection.

@maxme do you want these fixes to land on release 13.7 of WPiOS (currently frozen) or the next one 13.8?

[etoledom]

Works great! 🎉

Tested on iOS 13 and 12 ✅

I left a couple of questions as code comments, but ✅ since the issue is solved.
Great work!

[maxme]

@maxme do you want these fixes to land on release 13.7 of WPiOS (currently frozen) or the next one 13.8?

IMO, It got the criterias to get merged in the current frozen version:

• It's a bug fix.
• You added tests.
• It's not too big and not impacting the rest of the app too much (less prone to create a blocker).

So let's merge it in 13.7.

[frosty]

Looks good, just two small comments – but otherwise

Thanks for fixing this!

[SergioEstevao]

From my investigation we need to set them explicitly or else we will get the bug!

…

On Thu, 21 Nov 2019 at 13:20, James Frost ***@***.***> wrote: ***@***.**** approved this pull request. Looks good, just two small comments – but otherwise [image: ] Thanks for fixing this! ------------------------------ In Aztec/Classes/TextKit/TextView.swift <#1237 (comment)> : > attributes[.foregroundColor] = color } return attributes } - + + open lazy var defaultTextColor: UIColor? = { + let color: UIColor + if #available(iOS 13.0, *) { + color = UIColor.label You could just return directly in each branch of this if statement, and you can drop the UIColor? (e.g. return .label) ------------------------------ In Aztec/Classes/TextKit/TextViewPasteboardDelegate.swift <#1237 (comment)> : > @@ -80,6 +80,21 @@ open class AztecTextViewPasteboardDelegate: TextViewPasteboardDelegate { return true } + private func fixColors(in string: NSAttributedString, using baseColor: UIColor?) -> NSAttributedString { + guard #available(iOS 13.0, *) else { + return string + } + let colorToUse = baseColor ?? UIColor.label + + let newString = NSMutableAttributedString(attributedString: string) + newString.enumerateAttributes(in: newString.rangeOfEntireString, options: []) { (attributes, range, stop) in + if attributes[.foregroundColor] == nil { + newString.setAttributes([.foregroundColor: colorToUse], range: range) Out of interest, do we need to set color attributes, or can we just remove any that already exist there? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1237?email_source=notifications&email_token=AAE7CUP2M27S4QH2XMCV27LQU2DKTA5CNFSM4JPZL6VKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMQCNNA#pullrequestreview-320874164>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE7CUMALXKLJCKZCYUIFBTQU2DKTANCNFSM4JPZL6VA> .