Extend title view for big titles #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Example/Example/EditorDemoController.swift
|
|
||
| // MARK: - Title and Title placeholder position methods | ||
| func updateTitleHeight() { | ||
| let sizeThatShouldFitTheContent = titleTextField.sizeThatFits(CGSize(width:self.view.frame.size.width - ( 2 * Constants.margin), height: CGFloat.greatestFiniteMagnitude)) |
Contributor
There was a problem hiding this comment.
Maybe move the CGSize instantiation one line upwards, to aid readability?
- No need to use
selfnorsize.view.frame.widthshould do the trick!
| } | ||
|
|
||
| func updateTitlePlaceholderVisibility() { | ||
| self.titlePlaceholderLabel.isHidden = !self.titleTextField.text.isEmpty |
Contributor
|
Only thing i'm not really sure about is: since we don't currently support "Scrolling the Title" to get it out of the way, in the multiline title scenario, users might end up with something like this:
Note that "Line 1 ... 3" cannot be scrolled, and the edition area ends up being quite tight (this is on the iPhone SergioEstevao!). Thoughts on this one? (Maybe we wanna delay this a bit until we can also implement the scrollabe title behavior, or merge it, but cap the mechanism to just one line, temporarily?) |
Contributor
Author
|
@jleandroperez I will tackle the title view scrolling out of the way next. Just after this PR is in. |
jleandroperez
approved these changes
Mar 30, 2017
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
Sounds good to me @SergioEstevao!. Worst case scenario, we can always cap the title's height, temporarily.
Nice work!
brbrr
added a commit
that referenced
this pull request
Dec 1, 2017
* Add AztecUITests to AztecExample scheme * Add tests for #393 * Add #675 UI test and some refactoring * Add #465 UI test * Make tests work on iPhone SE * Updates after PR review * Add tests #771 & #768 * dont do missclick when mediaButton is not Hittable * Reset simulator state before test run * Check programatically whenever options strip is in expanded postion * minor changes, some work on PageObject refactoring * fix project structure * tweaking failed test * another tweak for failed test * tweak for swiping issue on iPhone SE * clean-up * Add some reliability to tests on bigger screens * Tests passing on iPads 🎉
brbrr
added a commit
that referenced
this pull request
Dec 8, 2017
* Add AztecUITests to AztecExample scheme * Add tests for #393 * Add #675 UI test and some refactoring * Add #465 UI test * Make tests work on iPhone SE * Updates after PR review * Add tests #771 & #768 * dont do missclick when mediaButton is not Hittable * Reset simulator state before test run * Check programatically whenever options strip is in expanded postion * minor changes, some work on PageObject refactoring * PageObject & first a bit complex formatting test * Add UnorderedListWithRemovedStyles test & some PO refactoring * Add complex styling test & further refactoring * Add few more tests 🎉 * New tests and refactoring: * Add more Formatting tests * Add Link related tests * Add AccesibilityIDs into EditorDemoControler * Refactor some tests to use PageObjects * fix locator name * Add Images Tests * Make tests pass on iPhone X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #385
Relate to this: wordpress-mobile/WordPress-iOS#6824
On this PR I'm converting the Title to an UITextView to allow multiple lines and adjusting the size of it depending of the text inserted.
I'm also adding a placeholder label because UITextView doesn't have placeholder labels!
How to test: