Blockquote + Lists: Fixing UI Glitch #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-within-list-glitch
diegoreymendez
approved these changes
Sep 6, 2017
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Working great!
Nice job.
| assert(index != startIndex) | ||
|
|
||
| let previousIndex = self.index(before: index) | ||
| guard previousIndex != endIndex else { |
Contributor
There was a problem hiding this comment.
As discussed privately, this will need to change in an upcoming PR since it's impossible to trigger this guard.
Documenting for history.
Contributor
Author
|
Thanks Diego! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645
Scenario: Unit Tests!
Please: Verify that the Unit Tests run correctly
Scenario: Blockquote Within List
Scenario: List Within Blockquote
Needs Review: @diegoreymendez
Thanks in advance!