Skip to content

Fixed Chinese input issue in header 1~6 #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2017
Merged

Fixed Chinese input issue in header 1~6 #814

merged 1 commit into from
Nov 10, 2017

Conversation

@azone
Copy link
Contributor

@azone azone commented Nov 8, 2017

Fixes #811

To test:

  1. Open editor
  2. Press return
  3. Turn Heading on (h1 or h2, ...)
  4. Input any Chinese characters and confirm
  5. Continue input Chinese characters and confirm

@jleandroperez jleandroperez self-requested a review November 8, 2017 21:26
jleandroperez
jleandroperez approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir!!

:shipit:

@jleandroperez jleandroperez merged commit b998881 into wordpress-mobile:develop Nov 10, 2017
@jleandroperez jleandroperez mentioned this pull request Nov 10, 2017
Closed
@diegoreymendez diegoreymendez added this to the Version 1.0.0 Beta 15 milestone Nov 24, 2017
@catalinatCore
Copy link

catalinatCore commented Nov 21, 2019

Thank you so much!!😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleandroperez jleandroperez jleandroperez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Bug

Projects

None yet

Milestone

Version 1.0.0 Beta 15

Development

Successfully merging this pull request may close these issues.

Can't input Chinese characters

4 participants

@azone @catalinatCore @jleandroperez @diegoreymendez