Chinese H1 Input: Running only upon replacement #820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // | ||
| if range.length > 0 { | ||
| let invalidateRange = NSMakeRange(range.location, attrString.length) | ||
| fixAttributes(in: invalidateRange) |
Contributor
There was a problem hiding this comment.
Is there any specific reason for calling fixAttributes() instead of invalidateAttributes()?
Invalidate attributes does the same, without forcing a synchronous execution when lazy attribute fixing is on. See the discussion here: https://developer.apple.com/documentation/uikit/nstextstorage/1534025-invalidateattributes
Contributor
Author
|
@diegoreymendez thanks for bringing that up!. Replaced |
Contributor
Author
|
Closing in favor of #836. @diegoreymendez is a genius!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're updating the workaround introduced via #814:
fixAttributes(vsinvalidateAttributes)Ref. #811
Needs Review: @diegoreymendez
To test:
sand tap over any of the replacement suggestionsVerify that the keyboard suggestion selected in (6) remains onscreen.