This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Adding check for emptyViewController. #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @frosty . Would you mind doing this one with wordpress-mobile/WordPress-iOS#9943 since they go together? Thank you!! |
frosty
approved these changes
Aug 9, 2018
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Just one comment, but happy to merge after that!
| - (void)addEmptyViewControllerToView | ||
| { | ||
| if (self.emptyViewController.view.superview == nil) { | ||
| if (self.emptyViewController && _emptyViewController.view.superview == nil) { |
Contributor
There was a problem hiding this comment.
This method switches between self.emptyViewController and _emptyViewController a few times – could we make them all the same?
ScoutHarris
deleted the
issue/9504-handle_nil_no_results_view_controller
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #wordpress-mobile/WordPress-iOS#9940
Since the Post Editor in WPiOS sometimes return nil for
emptyViewController, it was crashing when attempting to add it to the view. This adds a test to ensure it actually exists before doing so.To test: