Jetpack Focus: Adjust screenshots for site topic - #16967
Merged
Merged
Conversation
… site icon is moved to the overflow menu
Contributor
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16967-31db036.apk), or scanning this QR code: |
Contributor
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16967-31db036.apk), or scanning this QR code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #16900
This PR adjusts the
startNewSiteto account for narrower displays.To test:
Checkout the PR branch locally
Switch to
jetpackJalapenoDebugbuild variant.Launch an emulator or physical device that has a narrower display. I used a physical Pixel 5 device
Run the
jPScreenshotTestfromJPScreenshotTestin Android Studio to check that it succeeds.Emulator Setup Guide
Ideally we run the tests on an emulator created by fastlane. See the notes in the issue for how this can be done:
Close emulator & wipe data
Switch to a device with a wider display and rerun from step 4
Regression Notes
Potential unintended areas of impact
JP Screenshot tests no longer work
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually ran the JPScreenshotTest
What automated tests I added (or what prevented me from doing so)
This is an automated test
PR submission checklist:
RELEASE-NOTES.txtif necessary.