Skip to content

Jetpack Focus: Adjust screenshots for site topic - #16967

Merged
AjeshRPai merged 2 commits into
trunkfrom
issue/jetpack-screenshots-new-site-update
Aug 2, 2022
Merged

Jetpack Focus: Adjust screenshots for site topic#16967
AjeshRPai merged 2 commits into
trunkfrom
issue/jetpack-screenshots-new-site-update

Conversation

@zwarm

@zwarm zwarm commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

Parent #16900

This PR adjusts the startNewSite to account for narrower displays.

To test:

  1. Checkout the PR branch locally

  2. Switch to jetpackJalapenoDebug build variant.

  3. Launch an emulator or physical device that has a narrower display. I used a physical Pixel 5 device

  4. Run the jPScreenshotTest from JPScreenshotTest in Android Studio to check that it succeeds.

    ⚠️ Note: When running multiple times you may get fails with Hilt or sometimes wiremock. We are starting an investigation into upgrading our wiremock library (we are really, really, really, far behind). Hopefully that will fix the wiremock issues.

    Emulator Setup Guide

    Ideally we run the tests on an emulator created by fastlane. See the notes in the issue for how this can be done:

    Follow the guide in SCREENSHOT_DEVICE_SETUP.md to create a device like the ones we're using for screenshots automation (this won't be super easy as the guide is a bit outdated and if you're on an M1 Mac you have to change the generated .ini files manually to set the arm64 architecture or else the emultators won't start.

  5. Close emulator & wipe data

  6. Switch to a device with a wider display and rerun from step 4

Regression Notes

  1. Potential unintended areas of impact
    JP Screenshot tests no longer work

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually ran the JPScreenshotTest

  3. What automated tests I added (or what prevented me from doing so)
    This is an automated test

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added [Type] Task Jetpack App UI Tests Anything related to automated UI Tests. labels Jul 29, 2022
@zwarm zwarm added this to the 20.5 milestone Jul 29, 2022
@zwarm
zwarm requested a review from AjeshRPai July 29, 2022 12:03
@zwarm zwarm self-assigned this Jul 29, 2022
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16967-31db036.apk), or scanning this QR code:

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16967-31db036.apk), or scanning this QR code:

@AjeshRPai AjeshRPai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code changes and tested the changes as per the instructions. Everything looks good to me. Great Job @zwarm . 👍 🙌

@AjeshRPai
AjeshRPai merged commit 12aa9fa into trunk Aug 2, 2022
@AjeshRPai
AjeshRPai deleted the issue/jetpack-screenshots-new-site-update branch August 2, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jetpack App [Type] Task UI Tests Anything related to automated UI Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants