Merge release/20.5 after some tooling improvements - #17024
Merged
Conversation
- Ran `fastlane download_translations` - Then amended the commits that were done, to discard any updates to the `strings.xml` files (we don't want to pick any new string and translation outside of the regular code-freeze / release cycle), and only keep the changes to the `available_languages.xml` files that the tooling did.
[Tooling] Re-enable Jetpack Lint step on Buildkite
So that the GitHub Release is created once the two betas/final builds (WP+JP) have finished building and the `.aab` files are available
…nName and with PlayStore upload disabled
…y versionName and with PlayStore upload disabled" This reverts commit e174cc1.
…ease-on-ci [Tooling/CI] Automate creation of GitHub Release after beta/release builds
…ne-typo [Tooling/CI] Fix typo in pipeline
Now that we don't have `zalpha` anymore
Now that we removed Zalpha flavor
This manual bump of `versionCode=1260` was done so that developers would not experiment installation issues due to us removing the `zalpha` flavor and moving other flavors away from using the `alpha.versionCode` property (which we just deleted) in favor of the `versionCode` property.
Note that, because that change was done manually and without doing a beta to PlayStore alongside it, the `versionCode` updated in this commit does *not* reflect a `versionCode` last used in the PlayStore for the current `versionName`. That is, this commit temporarily make those properties not match the versions last uploaded in the PlayStore anymore (which were `versionCode=1259` for that `versionName=20.5-rc-1`).
This disconnection (with the values actually used for uploaded app bundled to PlayStore) was deemed acceptable though, to ease the transition made by removing the `zalpha` flavor and `alpha.version{Name,Code}` properties — See discussion in #17023 (comment)
This is a transcient state anyway, as the `versionName` and `versionCode` properties will go back to match the values for builds uploaded in PlayStore as soon as we do the next beta or final build.
[Tooling] Remove zalpha flavor and alpha versioning
AliSoftware
marked this pull request as ready for review
August 10, 2022 12:33
AliSoftware
enabled auto-merge
August 10, 2022 12:36
ParaskP7
approved these changes
Aug 10, 2022
ParaskP7
left a comment
ParaskP7
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 💯
I am blindly approving this PR as I reviewed and/or was following closely all those 4 PRs you mentioned there, which are all now part of this bigger PR to be merged to trunk.
Contributor
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17024-c2c2ae0.apk), or scanning this QR code:
|
Contributor
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17024-c2c2ae0.apk), or scanning this QR code:
|
AliSoftware
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently made a handful of tooling-only PRs to the
release/20.5branch (#17015, #17018, #17019, #17023), which were made in the release branch because those tooling changes would benefit Release Management duties and automation during this beta.This PR now lands those tooling improvements into
trunk:release/20.5withtrunksooner than later, even if there was no new beta created sincerelease/20.5->trunkthat will follow would have an easier-to-review diff.