🤖 Prevent navigation outside the domain details webview

[antonis]

Fixes #19501

Description

This PR prevents navigation outside of the domain details context. Any other url is intercepted and opened in the device’s browser instead.
It also extracts the common navigation delegate functionality used in two other places with d52d5b8

To test:

1. Enable the domain_management feature flag
2. Open the domain management (Me>Domains or `My Site>More>Domains>ALL)
3. Tap on a domain
4. Verify that the details page opens
5. Try to browse outside the domains scope (e.g. by visiting a support page)
6. Verify that the link opens in an external browser

Screen_recording_20231108_154509.mp4

Regression Notes

1. Potential unintended areas of impact
   campaign details webview and domain registration webview

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing and relied on existing DomainRegistrationCheckoutWebViewNavigationDelegateTest and CampaignDetailWebViewNavigationDelegateTest

3. What automated tests I added (or what prevented me from doing so)
   Added DomainManagementDetailsWebViewNavigationDelegateTest

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[antonis]

Please add tests for class DomainManagementDetailsWebViewClient (or add unit-tests-exemption label to ignore this)

Adding the unit-tests-exemption label since the core of the DomainManagementDetailsWebViewClient is tested with DomainManagementDetailsWebViewNavigationDelegateTest

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19570-01aa44d
	Commit	01aa44d
	Direct Download	wordpress-prototype-build-pr19570-01aa44d.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19570-01aa44d
	Commit	01aa44d
	Direct Download	jetpack-prototype-build-pr19570-01aa44d.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

	1 Warning
⚠️	Class DomainManagementDetailsWebViewClient is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

[justtwago]

Finally "purchased" a test domain to test it and it works nice! All the external links are opened in an external browser. Thanks for adding tests for the delegate! 🎸

[antonis]

Thank you for reviewing and testing @justtwago 🙇