Skip to content

Removes category selection from page pre-publishing options - #19656

Merged
justtwago merged 1 commit into
trunkfrom
fix/19557-remove-categories-from-page-publishing
Nov 27, 2023
Merged

Removes category selection from page pre-publishing options#19656
justtwago merged 1 commit into
trunkfrom
fix/19557-remove-categories-from-page-publishing

Conversation

@antonis

@antonis antonis commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

Fixes #19557

Description

This PR removes category selection from page pre-publishing options aligning with the current options available on the web

Screenshot 2023-11-23 at 3 34 05 PM

Before After
before Screenshot_20231123_153824

To Test:

  1. Create a page
  2. Press publish
  3. Verify that no category selection option is available in the prepublishing nudges

Regression Notes

  1. Potential unintended areas of impact

Prepublishing nudge for posts/pages

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

Added tests verifying the applied change


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19656-f207508
Commitf207508
Direct Downloadjetpack-prototype-build-pr19656-f207508.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19656-f207508
Commitf207508
Direct Downloadwordpress-prototype-build-pr19656-f207508.apk
Note: Google Login is not supported on these builds.

@antonis antonis modified the milestones: 23.8, 23.9 Nov 27, 2023

@justtwago justtwago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Antonis! Tested and didn't see the category section on a bottom sheet dialog. Thanks for adding more tests 🎉

@justtwago
justtwago merged commit 137daf3 into trunk Nov 27, 2023
@justtwago
justtwago deleted the fix/19557-remove-categories-from-page-publishing branch November 27, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pages: When publishing pages you see the prepublish modal that tells you select catergoris

3 participants