Skip to content

Move the Transfer Domain card below the main dashboard cards - #19676

Merged
antonis merged 1 commit into
trunkfrom
issue/19674-move-transfer-domain-card
Nov 28, 2023
Merged

Move the Transfer Domain card below the main dashboard cards#19676
antonis merged 1 commit into
trunkfrom
issue/19674-move-transfer-domain-card

Conversation

@justtwago

Copy link
Copy Markdown
Contributor

Fixes #19674

According to this reasearch (pcdRpT-4nr-p2#comment-7550) the Google Domain Transfer card has changed its position on the list below the key dashboard cards such as prompts, blaze, stats, draft posts, and social.

Before After
Screenshot_20231127_132550 Screenshot_20231127_132507

To Test:

  • Go to My Site tab
  • Make sure you can see the Reclaim your Google Domains card is below Today's Stats, Draft posts, Scheduled posts, Pages, Activity Log, and Blogging prompts cards. It should be just above the Personalize home tab card

Regression Notes

  1. Potential unintended areas of impact

    • The dashboard on the My Site tab
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19676-73700d2
Commit73700d2
Direct Downloadjetpack-prototype-build-pr19676-73700d2.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19676-73700d2
Commit73700d2
Direct Downloadwordpress-prototype-build-pr19676-73700d2.apk
Note: Google Login is not supported on these builds.

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @justtwago 🙇
I tested the app and the card appears in the expected order. The code change and the updated test also looks good 🎉

@antonis
antonis merged commit ee531ec into trunk Nov 28, 2023
@antonis
antonis deleted the issue/19674-move-transfer-domain-card branch November 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Domains Transfer card below the key dashboard cards

3 participants