Move the Transfer Domain card below the main dashboard cards - #19676
Merged
Conversation
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19676-73700d2 | |
| Commit | 73700d2 | |
| Direct Download | jetpack-prototype-build-pr19676-73700d2.apk |
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19676-73700d2 | |
| Commit | 73700d2 | |
| Direct Download | wordpress-prototype-build-pr19676-73700d2.apk |
antonis
approved these changes
Nov 28, 2023
antonis
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this @justtwago 🙇
I tested the app and the card appears in the expected order. The code change and the updated test also looks good 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #19674
According to this reasearch (pcdRpT-4nr-p2#comment-7550) the Google Domain Transfer card has changed its position on the list below the key dashboard cards such as prompts, blaze, stats, draft posts, and social.
To Test:
My SitetabReclaim your Google Domainscard is belowToday's Stats,Draft posts,Scheduled posts,Pages,Activity Log, andBlogging promptscards. It should be just above thePersonalize home tabcardRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: