New strings for popup for clear translations

[SiobhyB]

Description

The strings originally associated with the image optimization popup were updated in #19581. Instead of informing users that optimization is off by default, the popup should now inform users of the new on-by-default state.

However, as we only updated existing strings, the old message was still displaying in languages with outdated translations. This means the popup would display misleading and incorrect information for those with languages other than English (United States) selected. For example, the below compares the expected translation compared to what is currently displaying when English (United Kingdom) is selected.

Expected	Actual

With this PR, we now remove the old, now-redundant strings and replace them with completely new strings. As such, languages without translations will display the default English strings.

---

To Test

• Remove and install the app.
• Navigate to Me → App Settings and set any locale other than English (United States).
• Next, to upload media, navigate to either the My Site → Media or the post/page editor to add a media block.
• Following the steps to add media from your screen of choice and select the choose from my device option.
• Select one or multiple images and add them.
• Verify that the image optimization popup is displayed with the correct wording.

---

Regression Notes

1. Potential unintended areas of impact

   • As we're changing strings, unintended impact should be minimal, but may include translations in general.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manually tested a number of different languages to confirm the default strings are used.

3. What automated tests I added (or what prevented me from doing so)

   • Not applicable, this PR only includes changes to strings.

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

UI Changes Testing Checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19682-657c40b
	Commit	657c40b
	Direct Download	wordpress-prototype-build-pr19682-657c40b.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19682-657c40b
	Commit	657c40b
	Direct Download	jetpack-prototype-build-pr19682-657c40b.apk

Note: Google Login is not supported on these builds.

[AliSoftware]

That is indeed the right thing to do: strings should be considered immutable, and changing them should require you to use a new key (like you did here 👍) instead of changing the copy of an existing key, especially if the new copy is not just a to fix but changes the meaning. This immutability rule is exactly to avoid the kind of issue you encountered here. 😉

[fluiddot]

Good catch @SiobhyB, the changes look good to me 🎊 !