Skip to content

Changes domain placeholder to yourgroovydomain.com - #19688

Merged
justtwago merged 1 commit into
trunkfrom
task/free-domain-card-example-address
Nov 29, 2023
Merged

Changes domain placeholder to yourgroovydomain.com#19688
justtwago merged 1 commit into
trunkfrom
task/free-domain-card-example-address

Conversation

@antonis

@antonis antonis commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Reference p1701163435325639-slack-C05NS0YV7HS

Description

Changes the domain placeholder of the "Free domain with annual plan" card from domain.blog to yourgroovydomain.com.

Before After
Screenshot_20231129_122138 Screenshot_20231129_122407
Before Dark Theme After Dark Theme
Screenshot_20231129_122156 Screenshot_20231129_122350
Landscape Large fonts
Screenshot_20231129_122430 Screenshot_20231129_122531

To Test:

  1. Open the Jetpack app
  2. Scroll down the My site screen
  3. Verify that the placeholder domain is yourgroovydomain.com

Regression Notes

  1. Potential unintended areas of impact

N/A

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

This PR involves only a resource change


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@osullivanchris osullivanchris left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for fixing!

@justtwago justtwago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Antonis! Works as presented on the screenshots 👍

@justtwago
justtwago merged commit 576ea11 into trunk Nov 29, 2023
@justtwago
justtwago deleted the task/free-domain-card-example-address branch November 29, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants