Migrate GCM Registration Service from JobIntentService to WorkManager - #19701
Merged
ravishanker merged 9 commits intoNov 30, 2023
Merged
Conversation
For handling registration in background using WorkManager
to use Schedule in place of JobIntentService
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19701-086d1b5 | |
| Commit | 086d1b5 | |
| Direct Download | jetpack-prototype-build-pr19701-086d1b5.apk |
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19701-086d1b5 | |
| Commit | 086d1b5 | |
| Direct Download | wordpress-prototype-build-pr19701-086d1b5.apk |
irfano
approved these changes
Nov 30, 2023
irfano
left a comment
Member
There was a problem hiding this comment.
Thank you for taking care of this, Ravi! I believe this will significantly improve our crash-free metrics. 🚀
I tested it by attempting to receive push notifications in your test cases, and I successfully received them. Push notifications still work, and the diff LGTM! 👍🏻
I won't merge it now as I've added minor comments for you to review.
- mark workManager private - remove unused cancelScheduleRegistration
Contributor
Generated by 🚫 Danger |
ravishanker
deleted the
Migrate-GCMRegistrationService-from-JobIntentService-to-WorkManager
branch
November 30, 2023 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #16015
This PR migrated JobIntentService to WorkManager for GCM token registration at the startup, and authn stages
JobIntentService is deprecated, and known to cause crashes on low end devices, on below Android 10.
To Test:
Test 1
Test 2
Test 3
Test 4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.