Skip to content

[Bloganuary] Modal analytics tracking - #19706

Merged
thomashorta merged 6 commits into
feature/bloganuary-nudgefrom
issue/19685-bloganuary-nudge-modal-analytics
Dec 1, 2023
Merged

[Bloganuary] Modal analytics tracking#19706
thomashorta merged 6 commits into
feature/bloganuary-nudgefrom
issue/19685-bloganuary-nudge-modal-analytics

Conversation

@thomashorta

Copy link
Copy Markdown
Contributor

Part of #19685

Add tracking for the Bloganuary Learn More model based on specs (pctCYC-16J-p2).


To Test:

  1. Install and log into the app with a site that has Blogging Prompts available
  2. Go to the My Site dashboard
  3. Tap "Learn More" on the Bloganuary card
  4. Verify, in the logs, 🔵 Tracked: bloganuary_nudge_learn_more_modal_shown, Properties: {"prompts_enabled":[true if prompts are enabled, false otherwise]}
  5. Tap the CTA action
  6. Verify, in the logs, 🔵 Tracked: bloganuary_nudge_learn_more_modal_action_tapped, Properties: {"action":["dismiss" or "turn_on_prompts", depending if prompts are enabled or not]}

Modal dismissal:
Whenever the Modal is dismissed (no matter which action led to it), there should be tracking for dismissal. Test multiple dismiss methods (back button, close button, fling down, tap CTA) and verify 🔵 Tracked: bloganuary_nudge_learn_more_modal_dismissed in the app logs.


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Analytics tracker unit tests.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

No UI changes.

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

wpmobilebot commented Nov 30, 2023

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19706-ffedca9
Commitffedca9
Direct Downloadwordpress-prototype-build-pr19706-ffedca9.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

wpmobilebot commented Nov 30, 2023

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19706-ffedca9
Commitffedca9
Direct Downloadjetpack-prototype-build-pr19706-ffedca9.apk
Note: Google Login is not supported on these builds.

@RenanLukas RenanLukas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I like what you did with the unit tests 👍

It's working as expected and code LGTM.

@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Base automatically changed from issue/19685-bloganuary-nudge-modal-turn-prompts-on to feature/bloganuary-nudge December 1, 2023 15:31
@thomashorta
thomashorta merged commit 37c66a9 into feature/bloganuary-nudge Dec 1, 2023
@thomashorta
thomashorta deleted the issue/19685-bloganuary-nudge-modal-analytics branch December 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants