[Bloganuary] Modal analytics tracking - #19706
Merged
thomashorta merged 6 commits intoDec 1, 2023
Merged
Conversation
added 5 commits
November 30, 2023 18:03
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19706-ffedca9 | |
| Commit | ffedca9 | |
| Direct Download | wordpress-prototype-build-pr19706-ffedca9.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19706-ffedca9 | |
| Commit | ffedca9 | |
| Direct Download | jetpack-prototype-build-pr19706-ffedca9.apk |
RenanLukas
approved these changes
Dec 1, 2023
RenanLukas
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. I like what you did with the unit tests 👍
It's working as expected and code LGTM.
12 tasks
Generated by 🚫 dangerJS |
Contributor
Generated by 🚫 Danger |
Base automatically changed from
issue/19685-bloganuary-nudge-modal-turn-prompts-on
to
feature/bloganuary-nudge
December 1, 2023 15:31
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Part of #19685
Add tracking for the Bloganuary Learn More model based on specs (pctCYC-16J-p2).
To Test:
🔵 Tracked: bloganuary_nudge_learn_more_modal_shown, Properties: {"prompts_enabled":[true if prompts are enabled, false otherwise]}🔵 Tracked: bloganuary_nudge_learn_more_modal_action_tapped, Properties: {"action":["dismiss" or "turn_on_prompts", depending if prompts are enabled or not]}Modal dismissal:
Whenever the Modal is dismissed (no matter which action led to it), there should be tracking for dismissal. Test multiple dismiss methods (back button, close button, fling down, tap CTA) and verify
🔵 Tracked: bloganuary_nudge_learn_more_modal_dismissedin the app logs.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist:
No UI changes.