Skip to content

[Bloganuary] Make Bloganuary Nudge only be eligible in December - #19707

Merged
thomashorta merged 3 commits into
feature/bloganuary-nudgefrom
issue/bloganuary-nudge-eligible-only-in-december
Dec 1, 2023
Merged

[Bloganuary] Make Bloganuary Nudge only be eligible in December#19707
thomashorta merged 3 commits into
feature/bloganuary-nudgefrom
issue/bloganuary-nudge-eligible-only-in-december

Conversation

@thomashorta

Copy link
Copy Markdown
Contributor

Check if the current month is December for deciding if the Bloganuary Nudge should be shown.


To Test:

  1. Install and log into the Jetpack app using a site that has prompts available
  2. Make sure the bloganuary_dashboard_nudge FF is on in Debug Settings
  3. Go to your device settings -> Date
  4. Set the date to some month that is not December
  5. Go back to Jetpack -> My Site Dashboard
  6. Verify the Bloganuary card is not shown
  7. Go to your device settings -> Date
  8. Set the date to December
  9. Verify the Bloganuary card is shown

Regression Notes

  1. Potential unintended areas of impact

    • Bloganuary card is shown for other months or if other requirements don't match.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing, Unit tests.
  3. What automated tests I added (or what prevented me from doing so)

    • Added/update unit tests for the ViewModelSlice.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

No UI changes.

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19707-27cc1c1
Commit27cc1c1
Direct Downloadjetpack-prototype-build-pr19707-27cc1c1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19707-27cc1c1
Commit27cc1c1
Direct Downloadwordpress-prototype-build-pr19707-27cc1c1.apk
Note: Google Login is not supported on these builds.

@RenanLukas RenanLukas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's working as expected and code LGTM.

Base automatically changed from issue/19685-bloganuary-nudge-modal-analytics to feature/bloganuary-nudge December 1, 2023 15:32
@thomashorta
thomashorta merged commit 1b82252 into feature/bloganuary-nudge Dec 1, 2023
@thomashorta
thomashorta deleted the issue/bloganuary-nudge-eligible-only-in-december branch December 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants