Skip to content

[Reader Improvements] Show "View in browser" and "Share" actions in reader post details toolbar - #19731

Merged
RenanLukas merged 4 commits into
trunkfrom
issue/19729-reader-post-details-revert-removal-view-in-browser-and-share-from-toolbar
Dec 5, 2023
Merged

[Reader Improvements] Show "View in browser" and "Share" actions in reader post details toolbar#19731
RenanLukas merged 4 commits into
trunkfrom
issue/19729-reader-post-details-revert-removal-view-in-browser-and-share-from-toolbar

Conversation

@RenanLukas

@RenanLukas RenanLukas commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Fixes #19729


To Test:

1 - Install JP and sign in
2 - Open reader
3 - Tap on any post in any tab
4 - Verify that the "View in browser" and "Share" actions are shown in the toolbar
5 - Verify that both actions work as expected, including their analytics events. The analytics event for share action was changed and should look like this:

Tracked: item_shared_reader, Properties: {"blog_id":123,"feed_id":123,"follow":true,"source":"post_detail_toolbar"}

Discussion: p1701731047457609/1701688108.191079-slack-C01CW1VMLAF


Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    --


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@thomashorta thomashorta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and everything is working as expected! Thanks! :shipit:

it.blogId,
it.feedId,
it.isFollowedByCurrentUser,
SOURCE_POST_DETAIL_TOOLBAR,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏🏼

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19731-9a3e8e6
Commit9a3e8e6
Direct Downloadjetpack-prototype-build-pr19731-9a3e8e6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19731-9a3e8e6
Commit9a3e8e6
Direct Downloadwordpress-prototype-build-pr19731-9a3e8e6.apk
Note: Google Login is not supported on these builds.

@RenanLukas
RenanLukas merged commit 603bb10 into trunk Dec 5, 2023
@RenanLukas
RenanLukas deleted the issue/19729-reader-post-details-revert-removal-view-in-browser-and-share-from-toolbar branch December 5, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Reader Improvements] Revert Reader post details removal of "View in browser" and "Share" items from toolbar

3 participants