[Reader Improvements] Show "View in browser" and "Share" actions in reader post details toolbar - #19731
Merged
RenanLukas merged 4 commits intoDec 5, 2023
Conversation
…s toolbar after reader improvements
…_shared -> item_shared_reader)
Contributor
Generated by 🚫 Danger |
thomashorta
approved these changes
Dec 4, 2023
thomashorta
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me and everything is working as expected! Thanks! ![]()
| it.blogId, | ||
| it.feedId, | ||
| it.isFollowedByCurrentUser, | ||
| SOURCE_POST_DETAIL_TOOLBAR, |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19731-9a3e8e6 | |
| Commit | 9a3e8e6 | |
| Direct Download | jetpack-prototype-build-pr19731-9a3e8e6.apk |
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19731-9a3e8e6 | |
| Commit | 9a3e8e6 | |
| Direct Download | wordpress-prototype-build-pr19731-9a3e8e6.apk |
RenanLukas
deleted the
issue/19729-reader-post-details-revert-removal-view-in-browser-and-share-from-toolbar
branch
December 5, 2023 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #19729
To Test:
1 - Install JP and sign in
2 - Open reader
3 - Tap on any post in any tab
4 - Verify that the "View in browser" and "Share" actions are shown in the toolbar
5 - Verify that both actions work as expected, including their analytics events. The analytics event for share action was changed and should look like this:
Discussion: p1701731047457609/1701688108.191079-slack-C01CW1VMLAF
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: