Do not launch share intent for a page that is null - #19749
Merged
Conversation
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19749-0ad0d41 | |
| Commit | 0ad0d41 | |
| Direct Download | wordpress-prototype-build-pr19749-0ad0d41.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19749-0ad0d41 | |
| Commit | 0ad0d41 | |
| Direct Download | jetpack-prototype-build-pr19749-0ad0d41.apk |
antonis
approved these changes
Dec 7, 2023
antonis
left a comment
Contributor
There was a problem hiding this comment.
Thank you for picking this up @justtwago 🙇
The code change seems reasonable to me and I didn't notice any side effects in the app 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #19748
The problem seems to be occurred when the user tries to share a draft post that hasn't been saved to our local database -
PageStore, so it returns null for the selected post id. I couldn't reproduce it, though.To Test:
I haven't found a way to reproduce this bug since there should be a page on a drafts list that is not saved in the
PostStore.Please smoke test a page draft creation and generating a share link for the draft page.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: