Skip to content

Do not launch share intent for a page that is null - #19749

Merged
antonis merged 1 commit into
trunkfrom
issue/19748-copy-nullable-page-link
Dec 7, 2023
Merged

Do not launch share intent for a page that is null#19749
antonis merged 1 commit into
trunkfrom
issue/19748-copy-nullable-page-link

Conversation

@justtwago

@justtwago justtwago commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Fixes #19748

The problem seems to be occurred when the user tries to share a draft post that hasn't been saved to our local database - PageStore, so it returns null for the selected post id. I couldn't reproduce it, though.

To Test:

I haven't found a way to reproduce this bug since there should be a page on a drafts list that is not saved in the PostStore.
Please smoke test a page draft creation and generating a share link for the draft page.


Regression Notes

  1. Potential unintended areas of impact

    • Pages screen
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19749-0ad0d41
Commit0ad0d41
Direct Downloadwordpress-prototype-build-pr19749-0ad0d41.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19749-0ad0d41
Commit0ad0d41
Direct Downloadjetpack-prototype-build-pr19749-0ad0d41.apk
Note: Google Login is not supported on these builds.

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up @justtwago 🙇
The code change seems reasonable to me and I didn't notice any side effects in the app 🎉

@antonis
antonis merged commit f66f762 into trunk Dec 7, 2023
@antonis
antonis deleted the issue/19748-copy-nullable-page-link branch December 7, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException: org.wordpress.android.viewmodel.pages.PagesViewModel in copyPageLink

3 participants