Migrate :libs:processors to ksp
#20217
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,128 +1,131 @@ | ||
| @file:OptIn(KspExperimental::class) | ||
|
|
||
|
|
||
| package org.wordpress.android.processor | ||
|
|
||
| import com.google.devtools.ksp.KspExperimental | ||
| import com.google.devtools.ksp.containingFile | ||
| import com.google.devtools.ksp.getAnnotationsByType | ||
| import com.google.devtools.ksp.processing.CodeGenerator | ||
| import com.google.devtools.ksp.processing.Resolver | ||
| import com.google.devtools.ksp.processing.SymbolProcessor | ||
| import com.google.devtools.ksp.symbol.KSAnnotated | ||
| import com.google.devtools.ksp.symbol.KSClassDeclaration | ||
| import com.squareup.kotlinpoet.ksp.toTypeName | ||
| import com.squareup.kotlinpoet.ksp.writeTo | ||
| import org.wordpress.android.annotation.Experiment | ||
| import org.wordpress.android.annotation.Feature | ||
| import org.wordpress.android.annotation.RemoteFieldDefaultGenerater | ||
|
|
||
| @OptIn(KspExperimental::class) | ||
| class RemoteConfigProcessor( | ||
| private val codeGenerator: CodeGenerator, | ||
| ) : SymbolProcessor { | ||
| /** | ||
| * In the case of this processor, we only one need round. Generated files do not depend on each other | ||
| * or any other processor. | ||
| * | ||
| * See: https://github.com/google/ksp/issues/797#issuecomment-1041127747 | ||
| * Also: https://github.com/google/ksp/blob/a0cd7774a7f65cec45a50ecc8960ef5e4d47fc21/examples/playground/test-processor/src/main/kotlin/TestProcessor.kt#L20 | ||
| */ | ||
| private var invoked = false | ||
|
|
||
| override fun process(resolver: Resolver): List<KSAnnotated> { | ||
| if (invoked) { | ||
| return emptyList() | ||
| } | ||
|
|
||
| val remoteFeatures = resolver.getSymbolsWithAnnotation("org.wordpress.android.annotation.Feature") | ||
| .toList() | ||
|
|
||
| generateRemoteFeatureConfigDefaults(resolver, remoteFeatures) | ||
| generateRemoteFieldsConfigDefaults(resolver) | ||
| generateFeaturesInDevelopment(resolver) | ||
| generateRemoteFeatureConfigCheck(remoteFeatures) | ||
|
|
||
| invoked = true | ||
| return emptyList() | ||
| } | ||
|
|
||
| private fun generateRemoteFeatureConfigDefaults(resolver: Resolver, remoteFeatures: List<KSAnnotated>) { | ||
| val experiments = resolver.getSymbolsWithAnnotation("org.wordpress.android.annotation.Experiment") | ||
| .toList() | ||
|
|
||
| val defaults = (remoteFeatures + experiments) | ||
| .map { element: KSAnnotated -> | ||
| val featuresDefaults = element.getAnnotationsByType(Feature::class) | ||
| .toList().associate { annotation -> | ||
| annotation.remoteField to annotation.defaultValue.toString() | ||
| } | ||
| val experimentsDefaults = element.getAnnotationsByType(Experiment::class).toList() | ||
| .toList().associate { annotation -> | ||
| annotation.remoteField to annotation.defaultVariant | ||
| } | ||
| featuresDefaults + experimentsDefaults | ||
| }.flatMap { it.toList() } | ||
| .toMap() | ||
|
|
||
| if (defaults.isNotEmpty()) { | ||
| RemoteFeatureConfigDefaultsBuilder(defaults).getContent() | ||
| .writeTo( | ||
| codeGenerator, | ||
| aggregating = true, | ||
| originatingKSFiles = remoteFeatures.map { it.containingFile!! } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| private fun generateRemoteFieldsConfigDefaults(resolver: Resolver) { | ||
| val remoteFields = | ||
| resolver.getSymbolsWithAnnotation("org.wordpress.android.annotation.RemoteFieldDefaultGenerater") | ||
| .toList() | ||
| val remoteFieldDefaults = remoteFields | ||
| .associate { element: KSAnnotated -> | ||
| element.getAnnotationsByType(RemoteFieldDefaultGenerater::class) | ||
| .toList() | ||
| .first() | ||
| .let { annotation -> | ||
| annotation.remoteField to annotation.defaultValue | ||
| } | ||
| } | ||
|
|
||
| if(remoteFieldDefaults.isNotEmpty()) { | ||
| RemoteFieldConfigDefaultsBuilder(remoteFieldDefaults).getContent() | ||
| .writeTo( | ||
| codeGenerator, | ||
| aggregating = true, | ||
| originatingKSFiles = remoteFields.map { it.containingFile!! } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| private fun generateFeaturesInDevelopment(resolver: Resolver) { | ||
| val featuresInDevelopment = | ||
| resolver.getSymbolsWithAnnotation("org.wordpress.android.annotation.FeatureInDevelopment") | ||
| .filterIsInstance<KSClassDeclaration>() | ||
| .toList() | ||
| val featuresInDevelopmentDefaults = featuresInDevelopment | ||
| .map { it.simpleName.asString() } | ||
|
|
||
| if(featuresInDevelopmentDefaults.isNotEmpty()) { | ||
| FeaturesInDevelopmentDefaultsBuilder(featuresInDevelopmentDefaults).getContent() | ||
| .writeTo( | ||
| codeGenerator, | ||
| aggregating = true, | ||
| originatingKSFiles = featuresInDevelopment.map { it.containingFile!! } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| private fun generateRemoteFeatureConfigCheck(remoteFeatures: List<KSAnnotated>) { | ||
| if(remoteFeatures.isNotEmpty()) { | ||
| RemoteFeatureConfigCheckBuilder( | ||
| remoteFeatures.filterIsInstance<KSClassDeclaration>().map { it.asType(emptyList()).toTypeName() } | ||
| ).getContent().writeTo( | ||
| codeGenerator, | ||
| aggregating = true, | ||
| originatingKSFiles = remoteFeatures.map { it.containingFile!! } | ||
| ) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package org.wordpress.android.processor | ||
|
|
||
| import com.google.devtools.ksp.processing.SymbolProcessor | ||
| import com.google.devtools.ksp.processing.SymbolProcessorEnvironment | ||
| import com.google.devtools.ksp.processing.SymbolProcessorProvider | ||
|
|
||
| class RemoteConfigProcessorProvider : SymbolProcessorProvider { | ||
| override fun create( | ||
| environment: SymbolProcessorEnvironment | ||
| ): SymbolProcessor { | ||
| return RemoteConfigProcessor(environment.codeGenerator) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| org.wordpress.android.processor.RemoteConfigProcessorProvider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All output files are set to
aggregatingstrategy for incremental processing. They have to, as we gather annotations from all available files in the codebase.See https://kotlinlang.org/docs/ksp-incremental.html#aggregating-vs-isolating for more details.