Migrate `:libs:processors` to `ksp` #20217

wzieba · 2024-02-20T17:54:03Z

Description

This PR rewrites :libs:processors annotation processor from kapt to ksp, to unblock ksp migration in the whole project.

Please mind that this PR goes into feature branch ksp, not to trunk yet.

To Test:

TC1: Validate if generated classes did not change

Passed

Check out ec1baba
Run clean WordPress:kaptWordpressWasabiDebugKotlin
Save the content of generated classes somewhere. Those classes are
- RemoteFeatureConfigCheck
- FeaturesInDevelopment
- RemoteFeatureConfigDefaults
- RemoteFieldConfigDefaults
Check out this branch
Run clean WordPress:kspWordpressWasabiDebugKotlin
Look for the same classes as above (they'll be in a different directory). Assert that the content of those classes did not change Please mind, that, unfortunately, the order of generated code is different. Hint: you can sort the files e.g. alphabetically to make it easier to compare.

TC2: Incremental processing: add and remove a new development feature

Passed

Add a new remote feature class, in any place in the codebase, e.g.

 @FeatureInDevelopment
 class Foobar

Run WordPress:kspWordpressWasabiDebugKotlin
Assert Foobar is present in FeaturesInDevelopment generated file
Remove some @FeatureInDevelopment, e.g. LandOnTheEditorFeatureConfig
Run WordPress:kspWordpressWasabiDebugKotlin
Assert this feature is not present in FeaturesInDevelopment generated file

Other cases

In TC1 we validate content. In TC2 we validate incremental processing logic. Output files for other than @FeaturesInDevelopment annotations have the same setting - aggregating, so there's no strong need to test it.

But if you want to make sure, you can repeat TC2 with other annotations: @Experiment, @Feature and @RemoteFieldDefaultGenerater.

Regression Notes

Potential unintended areas of impact
- Code generation of classes:
  - RemoteFeatureConfigCheck
  - FeaturesInDevelopment
  - RemoteFeatureConfigDefaults
  - RemoteFieldConfigDefaults
What I did to test those areas of impact (or what existing automated tests I relied on)
- I wrote unit tests and smoke tested the app (instructions below)
What automated tests I added (or what prevented me from doing so)
- Unit tests:
  - Add :libs:processors unit tests #20213
  - :libs:processors annotation processing unit test #20227

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

wpmobilebot · 2024-02-20T18:13:13Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20217-3df71cf
	Commit	`3df71cf`
	Direct Download	`wordpress-prototype-build-pr20217-3df71cf.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-02-20T18:15:21Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20217-3df71cf
	Commit	`3df71cf`
	Direct Download	`jetpack-prototype-build-pr20217-3df71cf.apk`

Note: Google Login is not supported on these builds.

…idation

This commit brings back behaviour from previous, kapt implementation, of not generating classes if inputs for them are empty. This solves the problem of generating classes with empty content in different sourceset, e.g. `androidTest`. You can reproduce such problem in 80a80aa

codecov · 2024-02-21T10:36:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.41%. Comparing base (efb739f) to head (3df71cf).

Additional details and impacted files

@@            Coverage Diff             @@
##              ksp   #20217      +/-   ##
==========================================
+ Coverage   40.37%   40.41%   +0.04%     
==========================================
  Files        1469     1470       +1     
  Lines       67691    67719      +28     
  Branches    11209    11220      +11     
==========================================
+ Hits        27327    27368      +41     
+ Misses      37864    37857       -7     
+ Partials     2500     2494       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wpmobilebot · 2024-02-21T17:33:51Z

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 +--- androidx.databinding:viewbinding:8.1.0
 |    \--- androidx.annotation:annotation:1.0.0 -> 1.6.0
 |         \--- androidx.annotation:annotation-jvm:1.6.0
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.9.20
-|                   +--- org.jetbrains:annotations:13.0 -> 23.0.0
-|                   +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.20 (c)
-|                   +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.0 -> 1.9.10 (c)
-|                   \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (c)
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.9.22
+|                   +--- org.jetbrains:annotations:13.0 -> 23.0.0
+|                   +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (c)
+|                   +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.0 -> 1.9.10 (c)
+|                   \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.22 (c)
++--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
++--- androidx.webkit:webkit:1.10.0
+|    \--- androidx.core:core:1.1.0 -> 1.12.0
+|         +--- androidx.annotation:annotation-experimental:1.3.0 -> 1.3.1
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.9.22 (*)
+|         +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.6.2
+|         |    +--- androidx.lifecycle:lifecycle-common:2.6.2
+|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|         |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3
+|         |    |         \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3
+|         |    |              \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.7.3
+|         |    |                   +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20 -> 1.9.22
+|         |    |                   |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
+|         |    |                   \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20 -> 1.9.10
+|         |    |                        +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.10 -> 1.9.22 (*)
+|         |    |                        \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.10
+|         |    |                             \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.10 -> 1.9.22 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
++--- androidx.navigation:navigation-compose:2.7.6
+|    +--- androidx.activity:activity-compose:1.7.0 -> 1.8.0
+|    |    +--- androidx.activity:activity-ktx:1.8.0
+|    |    |    +--- androidx.activity:activity:1.8.0
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.1 -> 2.6.2
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.1 -> 2.6.2
+|    |    |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.12.0
+|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    |    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2
+|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    |    |    +--- androidx.savedstate:savedstate:1.2.1
+|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.1 -> 2.6.2
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1 -> 2.6.2
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    +--- androidx.savedstate:savedstate-ktx:1.2.1
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    |    +--- androidx.compose.runtime:runtime:1.0.1 -> 1.5.3
+|    |    |    \--- androidx.compose.runtime:runtime-android:1.5.3
+|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    +--- androidx.compose.runtime:runtime-saveable:1.0.1 -> 1.5.3
+|    |    |    \--- androidx.compose.runtime:runtime-saveable-android:1.5.3
+|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    +--- androidx.compose.ui:ui:1.0.1 -> 1.5.3
+|    |    |    \--- androidx.compose.ui:ui-android:1.5.3
+|    |    |         +--- androidx.compose.ui:ui-geometry:1.5.3
+|    |    |         |    \--- androidx.compose.ui:ui-geometry-android:1.5.3
+|    |    |         |         +--- androidx.compose.ui:ui-util:1.5.3
+|    |    |         |         |    \--- androidx.compose.ui:ui-util-android:1.5.3
+|    |    |         |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    |         +--- androidx.compose.ui:ui-graphics:1.5.3
+|    |    |         |    \--- androidx.compose.ui:ui-graphics-android:1.5.3
+|    |    |         |         +--- androidx.compose.ui:ui-unit:1.5.3
+|    |    |         |         |    \--- androidx.compose.ui:ui-unit-android:1.5.3
+|    |    |         |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    |         +--- androidx.compose.ui:ui-text:1.5.3
+|    |    |         |    \--- androidx.compose.ui:ui-text-android:1.5.3
+|    |    |         |         +--- androidx.emoji2:emoji2:1.2.0 -> 1.4.0
+|    |    |         |         |    \--- androidx.lifecycle:lifecycle-process:2.4.1 -> 2.6.2
+|    |    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    |         +--- androidx.customview:customview-poolingcontainer:1.0.0
+|    |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.22 (*)
+|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    +--- androidx.compose.animation:animation:1.5.1 -> 1.5.3
+|    |    \--- androidx.compose.animation:animation-android:1.5.3
+|    |         +--- androidx.compose.animation:animation-core:1.5.3
+|    |         |    \--- androidx.compose.animation:animation-core-android:1.5.3
+|    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
+|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |         +--- androidx.compose.foundation:foundation-layout:1.5.3
+|    |         |    \--- androidx.compose.foundation:foundation-layout-android:1.5.3
+|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
+|    +--- androidx.navigation:navigation-runtime-ktx:2.7.6
+|    |    +--- androidx.navigation:navigation-common-ktx:2.7.6
+|    |    |    \--- androidx.navigation:navigation-common:2.7.6
+|    |    |         +--- androidx.collection:collection-ktx:1.1.0
+|    |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.9.22 (*)
+|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    |    \--- androidx.navigation:navigation-runtime:2.7.6
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.10 -> 1.9.20 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.10
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.10 -> 1.9.20 (*)
-+--- androidx.webkit:webkit:1.10.0
-|    \--- androidx.core:core:1.1.0 -> 1.12.0
-|         +--- androidx.annotation:annotation-experimental:1.3.0 -> 1.3.1
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.9.20 (*)
-|         +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.6.2
-|         |    +--- androidx.lifecycle:lifecycle-common:2.6.2
-|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|         |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3
-|         |    |         \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3
-|         |    |              \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.7.3
-|         |    |                   +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20 -> 1.9.20
-|         |    |                   |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.20 (*)
-|         |    |                   \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20 -> 1.9.10 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-+--- androidx.navigation:navigation-compose:2.7.6
-|    +--- androidx.activity:activity-compose:1.7.0 -> 1.8.0
-|    |    +--- androidx.activity:activity-ktx:1.8.0
-|    |    |    +--- androidx.activity:activity:1.8.0
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.1 -> 2.6.2
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.1 -> 2.6.2
-|    |    |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.12.0
-|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2
-|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    |    |    +--- androidx.savedstate:savedstate:1.2.1
-|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.1 -> 2.6.2
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1 -> 2.6.2
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    +--- androidx.savedstate:savedstate-ktx:1.2.1
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    |    +--- androidx.compose.runtime:runtime:1.0.1 -> 1.5.3
-|    |    |    \--- androidx.compose.runtime:runtime-android:1.5.3
-|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    +--- androidx.compose.runtime:runtime-saveable:1.0.1 -> 1.5.3
-|    |    |    \--- androidx.compose.runtime:runtime-saveable-android:1.5.3
-|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    +--- androidx.compose.ui:ui:1.0.1 -> 1.5.3
-|    |    |    \--- androidx.compose.ui:ui-android:1.5.3
-|    |    |         +--- androidx.compose.ui:ui-geometry:1.5.3
-|    |    |         |    \--- androidx.compose.ui:ui-geometry-android:1.5.3
-|    |    |         |         +--- androidx.compose.ui:ui-util:1.5.3
-|    |    |         |         |    \--- androidx.compose.ui:ui-util-android:1.5.3
-|    |    |         |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    |         +--- androidx.compose.ui:ui-graphics:1.5.3
-|    |    |         |    \--- androidx.compose.ui:ui-graphics-android:1.5.3
-|    |    |         |         +--- androidx.compose.ui:ui-unit:1.5.3
-|    |    |         |         |    \--- androidx.compose.ui:ui-unit-android:1.5.3
-|    |    |         |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    |         +--- androidx.compose.ui:ui-text:1.5.3
-|    |    |         |    \--- androidx.compose.ui:ui-text-android:1.5.3
-|    |    |         |         +--- androidx.emoji2:emoji2:1.2.0 -> 1.4.0
-|    |    |         |         |    \--- androidx.lifecycle:lifecycle-process:2.4.1 -> 2.6.2
-|    |    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    |         +--- androidx.customview:customview-poolingcontainer:1.0.0
-|    |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.20 (*)
-|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    +--- androidx.compose.animation:animation:1.5.1 -> 1.5.3
-|    |    \--- androidx.compose.animation:animation-android:1.5.3
-|    |         +--- androidx.compose.animation:animation-core:1.5.3
-|    |         |    \--- androidx.compose.animation:animation-core-android:1.5.3
-|    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
-|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |         +--- androidx.compose.foundation:foundation-layout:1.5.3
-|    |         |    \--- androidx.compose.foundation:foundation-layout-android:1.5.3
-|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-|    +--- androidx.navigation:navigation-runtime-ktx:2.7.6
-|    |    +--- androidx.navigation:navigation-common-ktx:2.7.6
-|    |    |    \--- androidx.navigation:navigation-common:2.7.6
-|    |    |         +--- androidx.collection:collection-ktx:1.1.0
-|    |    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.9.20 (*)
-|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    |    \--- androidx.navigation:navigation-runtime:2.7.6
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
 +--- project :libs:analytics
 |    +--- com.automattic:Automattic-Tracks-Android:3.4.0
 |    |    \--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0
 |    |         +--- com.squareup.okio:okio:3.2.0 -> 3.6.0
 |    |         |    \--- com.squareup.okio:okio-jvm:3.6.0
-|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 -> 1.9.20 (*)
+|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 -> 1.9.22 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.20 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.22 (*)
 |    \--- androidx.preference:preference:1.2.0
 |         +--- androidx.appcompat:appcompat:1.1.0 -> 1.6.1
 |         |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2
 |         |    |    +--- androidx.loader:loader:1.0.0
 |         |    |    |    \--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2
-|         |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
+|         |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
-|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 -> 1.9.20 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 -> 1.9.22 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.9.20 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.9.22 (*)
 |         +--- androidx.fragment:fragment-ktx:1.3.6 -> 1.6.2
 |         |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.1 -> 2.6.2
-|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 -> 1.9.20 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 -> 1.9.22 (*)
 |         \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
 |              \--- androidx.window:window:1.0.0
-|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.9.20 (*)
+|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.9.22 (*)
 +--- project :libs:image-editor
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
+|    +--- androidx.navigation:navigation-fragment:2.5.3 -> 2.7.6
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22
+|         +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
+|         \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.9.22
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
-|    +--- androidx.navigation:navigation-fragment:2.5.3 -> 2.7.6
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
-|    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.10
-|         +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.10 -> 1.9.20 (*)
-|         \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.9.10
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.10 -> 1.9.20 (*)
 +--- project :libs:editor
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
 |    +--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.112.0
 |    |    +--- org.wordpress.react-native-libraries.v4:react-native-safe-area-context:4.6.3
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.20 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.22 (*)
 |    |    +--- org.wordpress.react-native-libraries.v4:react-native-webview:11.26.1
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.22 (*)
 |    |    \--- org.wordpress.react-native-libraries.v4:react-native-gesture-handler:2.10.2
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.20 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.22 (*)
-|    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.10 (*)
+|    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 (*)
 +--- org.wordpress:fluxc:{strictly 2.67.0} -> 2.67.0
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.22 (*)
 |    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0
 |    |    +--- androidx.sqlite:sqlite:2.3.0
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
 |    |    \--- androidx.sqlite:sqlite-framework:2.3.0
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
 |    \--- androidx.room:room-ktx:2.4.2
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.22 (*)
 +--- org.wordpress:login:1.14.0
 |    +--- androidx.credentials:credentials:1.2.0
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
 |    \--- androidx.credentials:credentials-play-services-auth:1.2.0
 |         +--- com.google.android.libraries.identity.googleid:googleid:1.1.0
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.9.20 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.9.22 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.20 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
 +--- com.automattic:about:1.4.0
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.9.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.9.22 (*)
 |    +--- androidx.compose.ui:ui-tooling:1.1.1 -> 1.5.3
 |    |    \--- androidx.compose.ui:ui-tooling-android:1.5.3
 |    |         +--- androidx.compose.material:material:1.0.0 -> 1.5.3
 |    |         |    \--- androidx.compose.material:material-android:1.5.3
 |    |         |         +--- androidx.compose.foundation:foundation:1.5.3
 |    |         |         |    \--- androidx.compose.foundation:foundation-android:1.5.3
-|    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
+|    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
 |    |         |         +--- androidx.compose.material:material-icons-core:1.5.3
 |    |         |         |    \--- androidx.compose.material:material-icons-core-android:1.5.3
-|    |         |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
+|    |         |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
-|    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
+|    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
 |    |         |         +--- androidx.compose.material:material-ripple:1.5.3
 |    |         |         |    \--- androidx.compose.material:material-ripple-android:1.5.3
-|    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
+|    |         |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
-|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
+|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
 |    |         +--- androidx.compose.ui:ui-tooling-data:1.5.3
 |    |         |    \--- androidx.compose.ui:ui-tooling-data-android:1.5.3
-|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
+|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
 |    |         +--- androidx.compose.ui:ui-tooling-preview:1.5.3
 |    |         |    \--- androidx.compose.ui:ui-tooling-preview-android:1.5.3
-|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
+|    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.20 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21 -> 1.9.22 (*)
 |    \--- com.google.android.material:compose-theme-adapter:1.1.1
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.9.20 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.9.22 (*)
 +--- com.automattic:stories:2.4.0
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.9.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.9.22 (*)
 |    +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc
 |    |    \--- org.jetbrains.kotlinx:kotlinx-serialization-runtime-jvm:1.0-M1-1.4.0-rc
-|    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.9.20 (*)
+|    |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.9.22 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.9.20 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.9.22 (*)
 |    +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.22 (*)
 |    +--- com.automattic.stories:photoeditor:2.4.0
 |    |    \--- androidx.camera:camera-core:1.0.0-alpha06 -> 1.2.3
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
 |    \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.6.2
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
 +--- com.google.android.flexbox:flexbox:3.0.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.9.20 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.9.22 (*)
 +--- androidx.work:work-runtime:2.8.1
 |    +--- androidx.lifecycle:lifecycle-service:2.1.0 -> 2.6.2
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.22 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.21 -> 1.9.20 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.21 -> 1.9.22 (*)
 +--- androidx.work:work-runtime-ktx:2.8.1
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.21 -> 1.9.20 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.21 -> 1.9.22 (*)
 +--- com.zendesk:support:5.1.2
 |    \--- com.zendesk:support-providers:5.1.2
 |         \--- com.zendesk:core:4.0.9
 |              \--- com.zendesk:java-common:2.0.0
-|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.9.20 (*)
+|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.9.22 (*)
 +--- com.google.dagger:hilt-android:2.50
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.20 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.20 -> 1.9.22 (*)
 +--- androidx.compose.runtime:runtime-livedata -> 1.5.3
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
 +--- io.coil-kt:coil-compose:2.4.0
 |    \--- io.coil-kt:coil-compose-base:2.4.0
 |         \--- io.coil-kt:coil-base:2.4.0
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.20 (*)
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.21 -> 1.9.22 (*)
 +--- androidx.compose.material3:material3:1.1.1 -> 1.1.2
-|    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20 -> 1.9.20 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20 -> 1.9.22 (*)
-\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.10 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 (*)

Please review and act accordingly

wzieba · 2024-02-22T11:00:50Z

libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigProcessor.kt

+    /**
+     * See: https://github.com/google/ksp/issues/797#issuecomment-1041127747
+     * Also: https://github.com/google/ksp/blob/a0cd7774a7f65cec45a50ecc8960ef5e4d47fc21/examples/playground/test-processor/src/main/kotlin/TestProcessor.kt#L20
+     */
+    private var invoked = false


In the case of this processor, we only one need round - generated files do not depend on each other or any other processors.

Thanks for the explanation. Minor suggestion: we could add your GitHub comment as a code comment (above the links to the discussion and example source), in case this assumption is later invalidated.

Sure! Added in 0292847

wzieba · 2024-02-22T11:02:31Z

libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigProcessor.kt

+            RemoteFeatureConfigDefaultsBuilder(defaults).getContent()
+                .writeTo(
+                    codeGenerator,
+                    aggregating = true,


All output files are set to aggregating strategy for incremental processing. They have to, as we gather annotations from all available files in the codebase.

See https://kotlinlang.org/docs/ksp-incremental.html#aggregating-vs-isolating for more details.

Remove the, now not necessairy, feature in every test. It's unnecessary now as condition was updated in RemoteConfigProcessor

mkevins

Thank you for migrating to KSP! The code changes look good, and I tested the scenarios described, and everything is working as expected. I did noticed, as you already mentioned that the generated outputs have a different order, but that should not affect anything.

I left one minor suggestion about adding more details to a code comment, in case multiple passes are required at some point in the future.

mkevins · 2024-02-23T03:05:42Z

libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigProcessor.kt

+    /**
+     * See: https://github.com/google/ksp/issues/797#issuecomment-1041127747
+     * Also: https://github.com/google/ksp/blob/a0cd7774a7f65cec45a50ecc8960ef5e4d47fc21/examples/playground/test-processor/src/main/kotlin/TestProcessor.kt#L20
+     */
+    private var invoked = false


Thanks for the explanation. Minor suggestion: we could add your GitHub comment as a code comment (above the links to the discussion and example source), in case this assumption is later invalidated.

mkevins · 2024-02-23T03:32:32Z

libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteConfigProcessorTest.kt

-        val result = compile(
-            listOf(
-                remoteFieldA,
-                featureA, /* adding a feature, as without it, annotation processor won't start */


Nice that we are able to fix this 😄

wzieba added 2 commits February 20, 2024 18:52

build: bump kotlin to 1.9.22, introduce ksp in libs:processors

53a4dd0

refactor: rewrite RemoteConfigProcessor to ksp

5490e4e

wzieba added the unit-tests-exemption label Feb 20, 2024

wzieba added 2 commits February 20, 2024 19:38

feat: specify correct originatingFiles to optimize ksp output inval…

80a80aa

…idation

wzieba added 3 commits February 21, 2024 18:02

Merge branch 'kapt_processing_tests' into migrate_processors_to_ksp

cec55db

Merge branch 'kapt_processing_tests' into migrate_processors_to_ksp

baa6ce5

test: adjust test setup for ksp usage

29409bc

Merge branch 'ksp' into migrate_processors_to_ksp

dd3a863

wzieba added Tooling and removed unit-tests-exemption labels Feb 22, 2024

wzieba marked this pull request as ready for review February 22, 2024 10:58

wzieba requested review from a team and mkevins and removed request for a team February 22, 2024 10:58

wzieba commented Feb 22, 2024

View reviewed changes

tests: simplify RemoteConfigProcessorTest

dfcf761

Remove the, now not necessairy, feature in every test. It's unnecessary now as condition was updated in RemoteConfigProcessor

mkevins approved these changes Feb 23, 2024

View reviewed changes

wzieba added 2 commits February 23, 2024 11:04

docs: add single-round processor comment

0292847

style: fix checkstyle

3df71cf

wzieba merged commit f44e5a6 into ksp Feb 23, 2024

wzieba deleted the migrate_processors_to_ksp branch February 23, 2024 10:44

wzieba mentioned this pull request Feb 23, 2024

Use ksp in the project #20264

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate `:libs:processors` to `ksp` #20217

Migrate `:libs:processors` to `ksp` #20217

Uh oh!

wzieba commented Feb 20, 2024 •

edited by mkevins

Loading

Uh oh!

wpmobilebot commented Feb 20, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 20, 2024 •

edited

Loading

Uh oh!

codecov bot commented Feb 21, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 21, 2024

Uh oh!

wzieba Feb 22, 2024 •

edited

Loading

Uh oh!

mkevins Feb 23, 2024

Uh oh!

wzieba Feb 23, 2024

Uh oh!

wzieba Feb 22, 2024

Uh oh!

mkevins left a comment

Uh oh!

mkevins Feb 23, 2024

Uh oh!

mkevins Feb 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Migrate :libs:processors to ksp #20217

Migrate :libs:processors to ksp #20217

Uh oh!

Conversation

wzieba commented Feb 20, 2024 • edited by mkevins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

To Test:

TC1: Validate if generated classes did not change

TC2: Incremental processing: add and remove a new development feature

Other cases

Regression Notes

PR Submission Checklist:

Testing Checklist:

Uh oh!

wpmobilebot commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wpmobilebot commented Feb 21, 2024

Uh oh!

wzieba Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkevins Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

wzieba Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

wzieba Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

mkevins left a comment

Choose a reason for hiding this comment

Uh oh!

mkevins Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

mkevins Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Migrate `:libs:processors` to `ksp` #20217

Migrate `:libs:processors` to `ksp` #20217

wzieba commented Feb 20, 2024 •

edited by mkevins

Loading

wpmobilebot commented Feb 20, 2024 •

edited

Loading

wpmobilebot commented Feb 20, 2024 •

edited

Loading

codecov bot commented Feb 21, 2024 •

edited

Loading

wzieba Feb 22, 2024 •

edited

Loading