Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 21, 2024

This PR migrates from using kapt to ksp, for running annotation processors of 3rd party libraries.

It targets a feature branch.


To Test:

Please run and smoke test the app.


Regression Notes

  1. Potential unintended areas of impact

    • The whole app
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • I smoke tested the app, we rely on automated tests on CI
  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20225-95da243
Commit95da243
Direct Downloadwordpress-prototype-build-pr20225-95da243.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20225-95da243
Commit95da243
Direct Downloadjetpack-prototype-build-pr20225-95da243.apk
Note: Google Login is not supported on these builds.

Base automatically changed from migrate_processors_to_ksp to ksp February 23, 2024 10:44
@wzieba wzieba added the Tooling label Feb 23, 2024
@wzieba wzieba marked this pull request as ready for review February 23, 2024 10:56
@wzieba wzieba requested review from a team, aditi-bhatia, jarvislin and justtwago and removed request for a team, aditi-bhatia and jarvislin February 23, 2024 10:56
@wzieba
Copy link
Contributor Author

wzieba commented Feb 23, 2024

@jarvislin and @aditi-bhatia are unavailable presently AFAIK, hence the next requests for selecting a reviewer.

@wzieba wzieba mentioned this pull request Feb 23, 2024
13 tasks
Copy link
Contributor

@justtwago justtwago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 Sorry for the delay.
Smoke tested the app and it works as usual with no major defects.
Thank you!

@wzieba
Copy link
Contributor Author

wzieba commented Feb 27, 2024

No worries, thank you!

@wzieba wzieba merged commit 1d8f53c into ksp Feb 27, 2024
@wzieba wzieba deleted the use_ksp_in_project branch February 27, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants