Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 23, 2024

Feature branch PR, consist of those PRs:
#20217
#20225

After merging it, the migration from kapt to ksp will be completed.


To Test:

Not necessary, as the code in this PR was tested in included PRs (listed above). Otherwise:

  1. Run the app, smoke test main features
  2. Focus if experiments and features which depend on feature flags work as expected.

Regression Notes

  1. Potential unintended areas of impact

    • Code related to experiments, feature flags and features in development
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • The code generated by old annotation processor is the same as the one generated by the new processor
  3. What automated tests I added (or what prevented me from doing so)


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 23, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20264-4bdc95d
Commit4bdc95d
Direct Downloadjetpack-prototype-build-pr20264-4bdc95d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 23, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20264-4bdc95d
Commit4bdc95d
Direct Downloadwordpress-prototype-build-pr20264-4bdc95d.apk
Note: Google Login is not supported on these builds.

@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.43%. Comparing base (618f509) to head (e409bf9).
Report is 2 commits behind head on trunk.

❗ Current head e409bf9 differs from pull request most recent head 4bdc95d. Consider uploading reports for the commit 4bdc95d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20264      +/-   ##
==========================================
+ Coverage   40.39%   40.43%   +0.04%     
==========================================
  Files        1461     1460       -1     
  Lines       67211    67188      -23     
  Branches    11163    11158       -5     
==========================================
+ Hits        27151    27170      +19     
+ Misses      37579    37542      -37     
+ Partials     2481     2476       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzieba wzieba added this to the 24.5 milestone Mar 4, 2024
@wzieba wzieba added Tooling Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Mar 4, 2024
@wzieba wzieba marked this pull request as ready for review March 4, 2024 10:41
@wzieba wzieba requested review from a team and antonis and removed request for a team March 4, 2024 10:41
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this @wzieba 🏅
The code changes look consistent and I didn't notice any change while sanity testing the app on a Pixel 8 (Android 14) 🎉

@wzieba wzieba enabled auto-merge March 11, 2024 10:50
@wzieba wzieba removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Mar 11, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wzieba wzieba merged commit f6a8606 into trunk Mar 11, 2024
@wzieba wzieba deleted the ksp branch July 9, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants