-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use ksp in the project
#20264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ksp in the project
#20264
Conversation
This commit brings back behaviour from previous, kapt implementation, of not generating classes if inputs for them are empty. This solves the problem of generating classes with empty content in different sourceset, e.g. `androidTest`. You can reproduce such problem in 80a80aa
Remove the, now not necessairy, feature in every test. It's unnecessary now as condition was updated in RemoteConfigProcessor
…_ksp Migrate `:libs:processors` to `ksp`
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20264-4bdc95d | |
| Commit | 4bdc95d | |
| Direct Download | jetpack-prototype-build-pr20264-4bdc95d.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20264-4bdc95d | |
| Commit | 4bdc95d | |
| Direct Download | wordpress-prototype-build-pr20264-4bdc95d.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20264 +/- ##
==========================================
+ Coverage 40.39% 40.43% +0.04%
==========================================
Files 1461 1460 -1
Lines 67211 67188 -23
Branches 11163 11158 -5
==========================================
+ Hits 27151 27170 +19
+ Misses 37579 37542 -37
+ Partials 2481 2476 -5 ☔ View full report in Codecov by Sentry. |
build: replace `kapt` with `ksp`
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this @wzieba 🏅
The code changes look consistent and I didn't notice any change while sanity testing the app on a Pixel 8 (Android 14) 🎉
|






Feature branch PR, consist of those PRs:
#20217
#20225
After merging it, the migration from
kapttokspwill be completed.To Test:
Not necessary, as the code in this PR was tested in included PRs (listed above). Otherwise:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
:libs:processorstoksp#20217 is carefully tested by automatic tests (some of them are also integration, not only unit)PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist: