Skip to content

CMM-952: Fix invisible back arrow on white images in Reader photo viewer - #23126

Merged
nbradbury merged 3 commits into
trunkfrom
issue/CMM-952-reader-fullscreen-image-white
Jul 22, 2026
Merged

CMM-952: Fix invisible back arrow on white images in Reader photo viewer#23126
nbradbury merged 3 commits into
trunkfrom
issue/CMM-952-reader-fullscreen-image-white

Conversation

@nbradbury

@nbradbury nbradbury commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

In the Reader's full-screen photo viewer, the toolbar's back arrow is always rendered white (via ThemeOverlay.AppCompat.Dark.ActionBar) on a fully transparent toolbar. When the viewed image is white or very light, the arrow blends into it and becomes invisible.

This adds a dark gradient scrim behind the toolbar (reader_photo_viewer_toolbar_scrim.xml, set as the toolbar's background) so the white arrow always has contrast, regardless of image color.

Testing instructions

Reader photo viewer contrast:

  1. Open a Reader post that contains a white or very light image (one is attached below).
  2. Tap the image to open the full-screen photo viewer.
  • Verify the back arrow is clearly visible against the light image.
  1. Tap the screen to toggle the toolbar.
  • Verify the scrim fades in/out together with the arrow, with no leftover dark band when the toolbar auto-hides.
  1. Repeat over a dark image and in dark mode.
  • Verify the arrow remains visible and the scrim is not distracting.
  1. In a post with multiple images, swipe between pages.
  • Verify the scrim behaves consistently on every image.
white-bordered

The back arrow was invisible over white/light images because the toolbar
is transparent and its icon is always white. Add a dark gradient scrim
behind the toolbar so the arrow stays legible regardless of image color.
@dangermattic

dangermattic commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot

wpmobilebot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr23126-1ab7cec
Build Number1498
Application IDorg.wordpress.android.prealpha
Commit1ab7cec
Installation URL2st2h8cho891o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr23126-1ab7cec
Build Number1498
Application IDcom.jetpack.android.prealpha
Commit1ab7cec
Installation URL0g81qns203u88
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@nbradbury
nbradbury marked this pull request as ready for review July 21, 2026 17:02
@nbradbury
nbradbury requested a review from adalpari July 21, 2026 17:02

@adalpari adalpari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@nbradbury
nbradbury enabled auto-merge (squash) July 22, 2026 09:46
@nbradbury
nbradbury merged commit 6fdf0bc into trunk Jul 22, 2026
22 of 27 checks passed
@nbradbury
nbradbury deleted the issue/CMM-952-reader-fullscreen-image-white branch July 22, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants