CMM-952: Fix invisible back arrow on white images in Reader photo viewer - #23126
Merged
Conversation
The back arrow was invisible over white/light images because the toolbar is transparent and its icon is always white. Add a dark gradient scrim behind the toolbar so the arrow stays legible regardless of image color.
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
…-fullscreen-image-white
nbradbury
marked this pull request as ready for review
July 21, 2026 17:02
…-fullscreen-image-white
nbradbury
enabled auto-merge (squash)
July 22, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
In the Reader's full-screen photo viewer, the toolbar's back arrow is always rendered white (via
ThemeOverlay.AppCompat.Dark.ActionBar) on a fully transparent toolbar. When the viewed image is white or very light, the arrow blends into it and becomes invisible.This adds a dark gradient scrim behind the toolbar (
reader_photo_viewer_toolbar_scrim.xml, set as the toolbar's background) so the white arrow always has contrast, regardless of image color.Testing instructions
Reader photo viewer contrast: